Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI against JRuby head #687

Open
Tracked by #691
vinistock opened this issue May 3, 2023 · 1 comment
Open
Tracked by #691

Add CI against JRuby head #687

vinistock opened this issue May 3, 2023 · 1 comment
Labels
chore Chore task good-first-issue Good for newcomers help-wanted Extra attention is needed pinned This issue or pull request is pinned and won't be marked as stale

Comments

@vinistock
Copy link
Member

We talked to the JRuby folks and they fixed the mismatch in their Ripper implementation when parsing optional arguments. We should introduce jruby-head to our CI to make sure everything else is passing.

Notes:

  • We don't need to run benchmarks on JRuby as well, only CRuby
  • We need to avoid requiring debug on JRuby since it is CRuby specific
@vinistock vinistock added good-first-issue Good for newcomers help-wanted Extra attention is needed chore Chore task labels May 3, 2023
@andyw8 andyw8 mentioned this issue May 3, 2023
Closed
@andyw8 andyw8 self-assigned this May 3, 2023
@andyw8
Copy link
Contributor

andyw8 commented May 3, 2023 •
edited
Loading

Gave it a quick shot here, it's currently failing on Nokogiri.

@andyw8 andyw8 removed their assignment May 3, 2023
@vinistock vinistock mentioned this issue May 3, 2023
Closed
@vinistock vinistock added the pinned This issue or pull request is pinned and won't be marked as stale label Jul 20, 2023
@tachyons tachyons mentioned this issue Dec 17, 2023
Closed
vinistock pushed a commit that referenced this issue Feb 28, 2024
@github-actions
Merge pull request #687 from Shopify/dependabot/npm_and_yarn/babel/co…
50e0bcd 
…re-7.22.8

Bump @babel/core from 7.22.6 to 7.22.8
This was referenced Mar 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Chore task good-first-issue Good for newcomers help-wanted Extra attention is needed pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Milestone
No milestone
2 participants
@andyw8 @vinistock