Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub check runs fail in 0.28.0 #930

Open
pfhayes opened this issue Aug 8, 2019 · 3 comments
Open

GitHub check runs fail in 0.28.0 #930

pfhayes opened this issue Aug 8, 2019 · 3 comments

Comments

@pfhayes
Copy link
Contributor

pfhayes commented Aug 8, 2019

We just upgraded from 0.26.0 to 0.28.0 and our GitHub status checks started failing, with the following error appearing in the sidekiq logs. Is this expected behaviour?

Aug 08 20:15:55 ip-172-31-43-20 env[3813]: 2019-08-08T20:15:55.072Z 3817 TID-gmyi8shc1 WARN: Octokit::Forbidden: GET https://api.github.com/repos/REDACTED/REDACTED/commits/REDACTED/check-runs: 403 - Resource not accessible by integration // See: https://developer.github.com/v3/checks/runs/#list-check-runs-for-a-specific-ref
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: 2019-08-08T20:15:55.072Z 3817 TID-gmyi8shc1 WARN: /home/shipit/.rvm/gems/ruby-2.5.1/gems/octokit-4.12.0/lib/octokit/response/raise_error.rb:16:in `on_complete'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-0.12.2/lib/faraday/response.rb:9:in `block in call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-0.12.2/lib/faraday/response.rb:61:in `on_complete'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-0.12.2/lib/faraday/response.rb:8:in `call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/shipit-engine-0.28.0/lib/shipit/strip_cache_control.rb:4:in `call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-http-cache-1.2.2/lib/faraday/http_cache.rb:303:in `fetch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-http-cache-1.2.2/lib/faraday/http_cache.rb:208:in `process'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-http-cache-1.2.2/lib/faraday/http_cache.rb:146:in `call!'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-http-cache-1.2.2/lib/faraday/http_cache.rb:119:in `call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-0.12.2/lib/faraday/rack_builder.rb:141:in `build_response'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-0.12.2/lib/faraday/connection.rb:386:in `run_request'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/faraday-0.12.2/lib/faraday/connection.rb:149:in `get'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sawyer-0.8.2/lib/sawyer/agent.rb:94:in `call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/octokit-4.12.0/lib/octokit/connection.rb:156:in `request'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/octokit-4.12.0/lib/octokit/connection.rb:84:in `paginate'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/shipit-engine-0.28.0/lib/shipit/octokit_check_runs.rb:3:in `check_runs'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/shipit-engine-0.28.0/app/models/shipit/commit.rb:143:in `block in refresh_check_runs!'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/shipit-engine-0.28.0/app/models/shipit/stack.rb:378:in `handle_github_redirections'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/shipit-engine-0.28.0/app/models/shipit/commit.rb:142:in `refresh_check_runs!'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/shipit-engine-0.28.0/app/jobs/shipit/refresh_check_runs_job.rb:7:in `perform'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/execution.rb:39:in `block in perform_now'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:109:in `block in run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/i18n-1.6.0/lib/i18n.rb:297:in `with_locale'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/translation.rb:9:in `block (2 levels) in <module:Translation>'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:118:in `instance_exec'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:118:in `block in run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/logging.rb:26:in `block (4 levels) in <module:Logging>'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/notifications.rb:168:in `block in instrument'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/notifications.rb:168:in `instrument'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/logging.rb:25:in `block (3 levels) in <module:Logging>'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/logging.rb:46:in `block in tag_logger'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/tagged_logging.rb:71:in `block in tagged'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/tagged_logging.rb:28:in `tagged'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/tagged_logging.rb:71:in `tagged'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/logging.rb:46:in `tag_logger'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/logging.rb:22:in `block (2 levels) in <module:Logging>'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:118:in `instance_exec'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:118:in `block in run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:136:in `run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/execution.rb:38:in `perform_now'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/execution.rb:24:in `block in execute'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:109:in `block in run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/railtie.rb:28:in `block (4 levels) in <class:Railtie>'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/execution_wrapper.rb:87:in `wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/reloader.rb:73:in `block in wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/execution_wrapper.rb:83:in `wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/reloader.rb:72:in `wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/railtie.rb:27:in `block (3 levels) in <class:Railtie>'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:118:in `instance_exec'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:118:in `block in run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:136:in `run_callbacks'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/execution.rb:22:in `execute'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activejob-5.2.3/lib/active_job/queue_adapters/sidekiq_adapter.rb:42:in `perform'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:192:in `execute_job'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:165:in `block (2 levels) in process'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:133:in `invoke'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:164:in `block in process'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:137:in `block (6 levels) in dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:109:in `local'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:136:in `block (5 levels) in dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/rails.rb:43:in `block in call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/execution_wrapper.rb:87:in `wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/reloader.rb:73:in `block in wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/execution_wrapper.rb:87:in `wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/activesupport-5.2.3/lib/active_support/reloader.rb:72:in `wrap'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/rails.rb:42:in `call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:132:in `block (4 levels) in dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:250:in `stats'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:127:in `block (3 levels) in dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/job_logger.rb:8:in `call'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:126:in `block (2 levels) in dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:74:in `global'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:125:in `block in dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:48:in `with_context'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:42:in `with_job_hash_context'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:124:in `dispatch'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:163:in `process'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:83:in `process_one'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:71:in `run'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:16:in `watchdog'
Aug 08 20:15:55 ip-172-31-43-20 env[3813]: /home/shipit/.rvm/gems/ruby-2.5.1/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:25:in `block in safe_thread'

Downgrading back to 0.26.0 fixes the issue
@casperisfine
Copy link
Contributor

Is this expected behaviour?

Clearly not. I mean it's a crash... 😉

I just took a look at the diff between the two versions: v0.26.0...v0.28.0 but fail to see any significant change around check runs.

Also the error message is quite odd, as we're definitely hitting this endpoint with an "integration" (GitHub App).

I'd suggest to contact GitHub support with the detailed request, it can sometime be something on their end.

@davefp
Copy link

davefp commented Aug 19, 2019

FWIW I had the same problem and it was because the Github app didn't have the right permissions set. Updating them to give access the checks API fixed things.

@pfhayes
Copy link
Contributor Author

pfhayes commented Aug 20, 2019

Thanks @davefp ! We'll give that a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davefp @pfhayes @casperisfine