Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed RPM is not displayed #49

Closed
sergeevabc opened this issue Nov 8, 2022 · 14 comments · May be fixed by #50
Closed

Speed RPM is not displayed #49

sergeevabc opened this issue Nov 8, 2022 · 14 comments · May be fixed by #50
Labels
bug Something isn't working

Comments

@sergeevabc
Copy link

Thinkpad X61, Windows 7 x64, TVicPort 4.1

Dear @Shuzhengz, let's compare the official TPFC 0.63 output with the output of your fork TPFC 2.1.5. As you can see, the laptop's fan is controlled just fine, but its RPM is not displayed, alas. Perhaps you could be so kind to invent some tweak to make it work again?

image image

@sergeevabc sergeevabc added the bug Something isn't working label Nov 8, 2022
@Shuzhengz
Copy link
Owner

hi
thank you for submitting the issue.
I'm actually quite busy right now but I'll get back to it once I have time, sorry about that

@Shuzhengz
Copy link
Owner

Hi
can you enable Log2File in the .ini file and then try to run the program again? It'll be very helpful if you can send any errors that are logged

Thank you

@sergeevabc
Copy link
Author

sergeevabc commented Nov 16, 2022

@Shuzhengz, I got logs from the original 0.63 and your build. Not sure if they are verbose enough to troubleshoot, but you requested them, so here we go.

Original
[16.11.2022 12:56:45] Current Config:
[16.11.2022 12:56:45]   Active= 2, Cycle= 5, FanBeep= 0 0, MaxReadErrors= 10
[16.11.2022 12:56:45]   IconLevels= 65 75 80, NoExtSensor= 0, Lev64Norm= 1
[16.11.2022 12:56:45]   Log2File= 1, Log2csv= 0, ShowAll= 0, IconColorFan= 1
[16.11.2022 12:56:45]   Levels= 60°C -> 0,  65°C -> 1,  75°C -> 3,  80°C -> 7,  90°C -> 64
[16.11.2022 12:56:45]   Levels2= 22°C -> 0,  33°C -> 1,  38°C -> 2,  44°C -> 3,  55°C -> 7,  66°C -> 64,  77°C -> 0x80
[16.11.2022 12:56:45]   SensorOffset1-12= 0 0 0 0 0 0 0 0 0 0 0 0 °C
[16.11.2022 12:56:45]   IgnoreSensors= no5, ProcessPriority= 2, IconCycle= 1
[16.11.2022 12:56:45]   BluetoothEDR= 1, NoWaitMessage= 1, ShowBiasedTemps= 1
[16.11.2022 12:56:45]   ManModeExit= 78, SecWinUptime= 0, SecStartDelay= 0

[16.11.2022 12:56:45] Windows uptime since boot 243534 sec., SecWinUptime= 0 sec.
[16.11.2022 12:56:45] Change Mode from BIOS->Smart, recalculate fan speed
[16.11.2022 12:56:45] Fan: 0x80 / Switch: 42°C (40; 42; 42; 38; 34; 0; 32; 0; 40; 37; 0; 0;)
[16.11.2022 12:56:45] Smart: Set fan control to 0x00, Mode 1, Result: OK
[16.11.2022 12:56:50] Fan: 0x00 / Switch: 42°C (40; 42; 42; 38; 34; 0; 32; 0; 40; 37; 0; 0;)
[16.11.2022 12:56:50] On close: Set fan control to 0x80, Result: OK
[16.11.2022 12:56:50] Exiting ProcessDialog
Your build
[16.11.2022 12:57:10] Current Config:
[16.11.2022 12:57:10]   Active= 2, Cycle= 5, FanBeep= 0 0, MaxReadErrors= 10
[16.11.2022 12:57:10]   IconLevels= 65 75 80, NoExtSensor= 0, Lev64Norm= 1
[16.11.2022 12:57:10]   Log2File= 1, Log2csv= 0, ShowAll= 0, IconColorFan= 1
[16.11.2022 12:57:10]   Levels= 50° C -> 0,  60° C -> 1,  70° C -> 2,  80° C -> 4,  90° C -> 7
[16.11.2022 12:57:10]   SensorOffset1-12= 0 0 0 0 0 0 0 0 0 0 0 0 ° C
[16.11.2022 12:57:10]   IgnoreSensors= no5, ProcessPriority= 2, IconCycle= 1
[16.11.2022 12:57:10]   BluetoothEDR= 1, NoWaitMessage= 1, ShowBiasedTemps= 1
[16.11.2022 12:57:10]   ManModeExit= 78, SecWinUptime= 0, SecStartDelay= 0

[16.11.2022 12:57:10] Windows uptime since boot 243559 sec., SecWinUptime= 0 sec.
[16.11.2022 12:57:10] Change Mode from BIOS->Smart, recalculate fan speed
[16.11.2022 12:57:11] Fan: 0x80 / Switch: 42° C (40; 42; 42; 38; 34; 0; 32; 0; 40; 38; 0; 0;)
[16.11.2022 12:57:11] Smart: Set fan control to 0x00, Result: [i=0] OK
[16.11.2022 12:57:17] Fan: 0x00 / Switch: 42° C (40; 42; 42; 38; 34; 0; 32; 0; 40; 38; 0; 0;)
[16.11.2022 12:57:17] On close: Set fan control to 0x80, Result: [i=0] OK
[16.11.2022 12:57:17] Exiting ProcessDialog

@Shuzhengz
Copy link
Owner

Shuzhengz commented Nov 16, 2022

Oh okay, from the logs it seems like the issue is not with error reading from EC, but rather the program confused over the single fan (it's designed to work on dual fan devices).

I'll try and work on a fix

Thank you

@Shuzhengz
Copy link
Owner

Sorry for getting back to this late, can you try this build and see if it works?
2.1.6.zip

The source code is in PR #50
Thanks

@sergeevabc
Copy link
Author

…and see if it works?

Nope.

image

@Shuzhengz
Copy link
Owner

Ok I changed the fan switch on EC to 0x2F and it might work, here is the new build
Source code is still in PR #50

@sergeevabc
Copy link
Author

Alas, still not there.

image

@jmauro
Copy link

jmauro commented Jan 9, 2023

Hello,

I am also having the same issue (v2.1.5 Dual Fan) on a P15s:
image

Do you need more debug information?

Kind regards,
JM

NOTE: I know it is also a mono fan 😉, apart from the rpm report everything works fine.

@Shuzhengz
Copy link
Owner

Hello,

I am also having the same issue (v2.1.5 Dual Fan) on a P15s: image

Do you need more debug information?

Kind regards, JM

NOTE: I know it is also a mono fan 😉, apart from the rpm report everything works fine.

Oh it seems like the second fan display is working for you, maybe try this build and see if it helps (https://github.com/Shuzhengz/TPFanCtrl2/files/10321212/Debug.zip), but I think the problem might be a different EC address for older thinkpads though

Thank you

@felipealvesgnu
Copy link

felipealvesgnu commented Mar 18, 2023

Hello,

I am also having the same issue (v2.1.5 Dual Fan) on a P15s: image

Do you need more debug information?

Kind regards, JM

NOTE: I know it is also a mono fan 😉, apart from the rpm report everything works fine.

I'm having the same issue as well, my laptop model is:
Lenovo ThinkPad T14 G2 i5-1145G7

@Shuzhengz Can you help on that ?

@Shuzhengz
Copy link
Owner

yeah, sorry I forgot about this, I'll try to get it fixed next week after finishing finals

@Vampx
Copy link

Vampx commented Mar 30, 2023

image
I am also having the same issue ,looking forward to the next version

@Shuzhengz
Copy link
Owner

Sorry about the delay, it seems like your RPM readout is set to a wrong address on the EC (65535 RPM is not a realisic fan speed, it should be in the thousands, not tens of thousands). The fix would be to find the correct address for the fan speed by reading the EC using RW-Everything, but unfortunately the program stopped working a few months ago on my device. I thought it was a bug with Windows and was waiting it out for them to fix it with an update, but it still isn't fixed, and I won't be able to fix the issue without knowing the correct address. You could try to find it yourself, I wrote the instruction to do so in another issue here, but yeah I won't be able to fix it without the EC address. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants