Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove geo_vs_neff.npy #134

Open
lukasc-ubc opened this issue Nov 23, 2020 · 1 comment
Open

remove geo_vs_neff.npy #134

lukasc-ubc opened this issue Nov 23, 2020 · 1 comment
Assignees

Comments

@lukasc-ubc
Copy link
Member

@jaspreetj

Regarding the file you added, it is huge, and takes forever for people to install.

https://github.com/SiEPIC/SiEPIC-Tools/blob/master/klayout_dot_config/python/SiEPIC/lumerical/geo_vs_neff.npy

Could you please:

  1. compress it? @mustafacc suggests npz format

  2. this file should be PDK and Waveguide-type specific. So it should go into each PDK, not in the Tool. And there should be multiple of these files, one per waveguide. I suggest supporting only strip waveguides in the EBeam PDK for now. And adding in your function a check on a per active technology PDK basis that checks if it there.

thanks
Lukas

@jaspreetj
Copy link
Collaborator

I agree, we should just remove the file from tools altogether, and add it to a PDK instead. I need to check what use-cases are we using the file for and remove it accordingly while patching the use-cases.

@jaspreetj jaspreetj self-assigned this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants