PolicyTypeHash validation requires size check

[Alrighttt]

core/types/policy.go

Line 155 in 0f61e58

case PolicyTypeHash:

An additional check on the size of the preimage must be performed in this case.

I recommend checking that the preimage is 32 bytes. Technically you can support preimages less than 32 bytes, but there is no practical use for this.

See:
https://gist.github.com/markblundeberg/7a932c98179de2190049f5823907c016

[Alrighttt]

Exact size check of length(preimage) == 32 is recommended, but if it will support a variable size, the size must be configurable.

ie,

type PolicyTypeHash struct {
	Len  uint16
	Hash Hash256
}

[lukechampine]

Is 32 the recommended length because, in practice, these preimages are always 32-byte randomly-generated secrets? (Is there any atomic swap protocol that uses a different length secret?)

I suppose there's little point in making in variable-size, since you can always hash the preimage twice -- that is, you can always hash a preimage to get an exactly-32-byte preimage for use with PolicyTypeHash.

[Alrighttt]

I suppose there's little point in making in variable-size, since you can always hash the preimage twice -- that is, you can always hash a preimage to get an exactly-32-byte preimage for use with PolicyTypeHash.

Yes, exactly. Thanks for the prompt fix.