Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to print block attributes in their original order in stringifySFC #21

Open
3 tasks
Sidnioulz opened this issue Aug 24, 2023 · 0 comments
Open
3 tasks
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@Sidnioulz
Copy link
Owner

Context

stringifySFC is responsible for re-printing SFC files once all blocks have been transformed. It does not necessarily print blocks, or block attributes, in the same order as the source file, even though those are not affected by the codemod functions.

Why this is a problem

This creates a lot of noise on blocks when applying a codemod to a large codebase.

To do:

  • Provide the right context to stringifySFC's helpers so they can re-print block attributes in the right order
  • Write unit tests with setup and lang="ts"
  • Check if block order is respected or also needs adjusting
@Sidnioulz Sidnioulz added enhancement New feature or request good first issue Good for newcomers labels Aug 24, 2023
@Sidnioulz Sidnioulz added this to the v1 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant