Cleanup warning

[smartin-vossloh]

This short series cleans up warning occurring at build for dsp3 bootloader and application.

[smartin-vossloh]

@nvincent-vossloh Do you know why this code has been added:
https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in https://github.com/SiemaApplications/mcuboot/commit/1fb66a19b3981effdb504076831250286d7d7ddc)

whereas this definition was already set here, from the device-tree:
https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in https://github.com/SiemaApplications/mcuboot/commit/66cdd46b4494be95ea549db811bad242b253c51e)

?

I wonder whether the best fix should be removing these lines instead:
https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110

Any opinion?

[nvincent-vossloh]

@nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)

whereas this definition was already set here, from the device-tree: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in 66cdd46)

?

I wonder whether the best fix should be removing these lines instead: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110

Any opinion?

In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead.
We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed.

You can have a look at the branch used in vog: https://github.com/SiemaApplications/mcuboot/blob/vog/zephyr_3.4/boot/zephyr/include/mcuboot_config/mcuboot_config.h
Only the value from the device tree seems to be used.

[smartin-vossloh]

@nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)
whereas this definition was already set here, from the device-tree: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in 66cdd46)
?
I wonder whether the best fix should be removing these lines instead: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110
Any opinion?

In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead. We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed.

You can have a look at the branch used in vog: https://github.com/SiemaApplications/mcuboot/blob/vog/zephyr_3.4/boot/zephyr/include/mcuboot_config/mcuboot_config.h Only the value from the device tree seems to be used.

And I have just found this: > @nvincent-vossloh Do you know why this code has been added: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110 (in 1fb66a1)

whereas this definition was already set here, from the device-tree: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L246-L252 (in 66cdd46)
?
I wonder whether the best fix should be removing these lines instead: https://github.com/SiemaApplications/mcuboot/blob/dsp3/zephyr_3.2/boot/zephyr/include/mcuboot_config/mcuboot_config.h#L106-L110
Any opinion?

In earlier version of mcuboot/zephyr, the definition was not taken from the device tree and mcuboot did not supported the aligment of the stm32h7. The options provided by mcuboot config could not be set to the proper value and the config from zephyr was taken instead. We update to newer version of mcuboot/zephyr the upstream code then supported the aligment of the h7 but the custom fix was not removed.

You can have a look at the branch used in vog/zephyr_3.2: 9bbaf5a

So, I will cherry-pick your fix.