Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about preproc.py, quote sub is different to fasttext get-wikimedia.sh #1

Open
cjrh opened this issue Oct 11, 2022 · 0 comments

Comments

@cjrh
Copy link

cjrh commented Oct 11, 2022

I think I found a bug in the preproc.py script for string normalization here: https://gist.github.com/bittlingmayer/7139a6a75ba0dbbc3a06325394ae3a13#file-ft_wiki_preproc-py-L17

image

The Python script appears to replace the double-quote with a space, but the original sed surrounds the double quote with spaces. Is this an error?

Unrelated, (but since I have your attention ;), do you know whether the same preprocessing rules were used for the common crawl models? I'm asking specifically about the cc.en.300.bin fasttext model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant