Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.3 support for fix_packages #75

Open
sbulen opened this issue May 18, 2024 · 0 comments
Open

PHP 7.3 support for fix_packages #75

sbulen opened this issue May 18, 2024 · 0 comments

Comments

@sbulen
Copy link
Contributor

sbulen commented May 18, 2024

Class type declarations were added in PHP 7.4. In theory we still support older versions of PHP...

So... In PHP 7.3, this throws an error:

private bool $isInstalling;

PHP Parse error: syntax error, unexpected 'bool' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /var/www/html/forum/fix_packages.php on line 90

I believe this is the only tweak needed to support 7.3.

This was reported in the forum:
https://www.simplemachines.org/community/index.php?topic=588937.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant