Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich content editor to product detail (description field) #84

Open
crhistianramirez opened this issue Mar 24, 2023 · 1 comment
Open
Labels
enhancement New feature or request not ready This issue is not a priority and/or ready to be worked on at this time.

Comments

@crhistianramirez
Copy link
Collaborator

We'd like to use tiptap since that is what is being used by content hub and will allow maximum compatibility if/when we add content hub integration

This editor should integrate with react-hook-form so that we can get some nice validation, particularly for validating string length since OrderCloud has a maximum of 2,000 characters. This 2,000 character limit should be enforced and should handle characters not visible to users as well.

Check out the components in react-hook-form for examples on how to wire up components with react-hook-form, and of course the react-hook-form docs. We are using useController

@crhistianramirez crhistianramirez added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 24, 2023
@robertsoniv robertsoniv removed this from the Design & Patterns milestone Apr 28, 2023
@robertsoniv
Copy link
Collaborator

Let's wait on this until we support contenthub one driven product information. They already support rich text / multi language.

@robertsoniv robertsoniv removed good first issue Good for newcomers help wanted Extra attention is needed labels May 4, 2023
@robertsoniv robertsoniv added invalid This doesn't seem right not ready This issue is not a priority and/or ready to be worked on at this time. and removed invalid This doesn't seem right labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not ready This issue is not a priority and/or ready to be worked on at this time.
Projects
Development

No branches or pull requests

2 participants