Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-squashing commits in pull-requests #385

Open
ilchenkob opened this issue Oct 20, 2020 · 0 comments
Open

Auto-squashing commits in pull-requests #385

ilchenkob opened this issue Oct 20, 2020 · 0 comments

Comments

@ilchenkob
Copy link
Contributor

This is not an issue rather suggestion how to improve overall process of contribution into this repo.

CONTRIBUTING.md states:

When submitting a pull request to the docker-images repo, we ask that you squash your commits before we merge.

But GitHub allows to do it automatically during the pull-request merge. There is an option called Squash and merge your pull request commits

Expected behavior

An author of a pull-request can push few commits into PR respectively to code-review comments and all commits will be squashed when PR will be merged.

Actual behavior

An author needs to squash commits manually whenever new commit has been made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant