From 99bb6e0a43b820b312c66e0972fa78be60367769 Mon Sep 17 00:00:00 2001 From: illiakovalenko Date: Fri, 15 Dec 2023 17:54:13 +0200 Subject: [PATCH 1/2] [Chore] Removed "npm" field from "engines" property --- CONTRIBUTING.md | 2 +- packages/create-sitecore-jss/package.json | 3 +-- packages/sitecore-jss-angular-schematics/package.json | 3 +-- packages/sitecore-jss-angular/package.json | 3 +-- packages/sitecore-jss-cli/package.json | 3 +-- packages/sitecore-jss-dev-tools/package.json | 3 +-- packages/sitecore-jss-forms/package.json | 3 +-- packages/sitecore-jss-nextjs/package.json | 3 +-- packages/sitecore-jss-proxy/package.json | 3 +-- packages/sitecore-jss-react-forms/package.json | 3 +-- packages/sitecore-jss-react-native/package.json | 3 +-- packages/sitecore-jss-react/package.json | 3 +-- packages/sitecore-jss-rendering-host/package.json | 3 +-- packages/sitecore-jss-vue/package.json | 3 +-- packages/sitecore-jss/package.json | 3 +-- 15 files changed, 15 insertions(+), 29 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 10d1555854..9d188a4482 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,7 @@ Want to contribute to Sitecore JavaScript Services? There are a few things you n ## Pre-requisites: - `node.js` (Use version `>= 18` or [Active LTS](https://nodejs.org/en/about/releases/)) installed (cmd `node -v` to test). -- `npm` (`>= 10`) installed (cmd `npm -v` to test). +- `npm` (`>= 9`) installed (cmd `npm -v` to test). Install yarn globally: diff --git a/packages/create-sitecore-jss/package.json b/packages/create-sitecore-jss/package.json index a3b16df417..774b3a0dee 100644 --- a/packages/create-sitecore-jss/package.json +++ b/packages/create-sitecore-jss/package.json @@ -12,8 +12,7 @@ "coverage": "nyc npm test" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "repository": { "type": "git", diff --git a/packages/sitecore-jss-angular-schematics/package.json b/packages/sitecore-jss-angular-schematics/package.json index 3e84f0c650..3a76cff0f0 100644 --- a/packages/sitecore-jss-angular-schematics/package.json +++ b/packages/sitecore-jss-angular-schematics/package.json @@ -10,8 +10,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-angular-schematics src/jss-component/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-angular/package.json b/packages/sitecore-jss-angular/package.json index 152edcfefb..71902466ee 100644 --- a/packages/sitecore-jss-angular/package.json +++ b/packages/sitecore-jss-angular/package.json @@ -11,8 +11,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-angular src/public_api.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-cli/package.json b/packages/sitecore-jss-cli/package.json index 785be01c96..0b3ec0a418 100644 --- a/packages/sitecore-jss-cli/package.json +++ b/packages/sitecore-jss-cli/package.json @@ -16,8 +16,7 @@ "coverage": "nyc --require ts-node/register/transpile-only npm test" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "preferGlobal": true, "bin": { diff --git a/packages/sitecore-jss-dev-tools/package.json b/packages/sitecore-jss-dev-tools/package.json index d0dc72a5f2..a556257055 100644 --- a/packages/sitecore-jss-dev-tools/package.json +++ b/packages/sitecore-jss-dev-tools/package.json @@ -16,8 +16,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-dev-tools src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "bin": { "scjss-deploy": "./dist/cjs/bin/deploy.js", diff --git a/packages/sitecore-jss-forms/package.json b/packages/sitecore-jss-forms/package.json index 1338a43aa7..a8eb64e210 100644 --- a/packages/sitecore-jss-forms/package.json +++ b/packages/sitecore-jss-forms/package.json @@ -14,8 +14,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-forms src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-nextjs/package.json b/packages/sitecore-jss-nextjs/package.json index 4c5167a660..c5a860bf6e 100644 --- a/packages/sitecore-jss-nextjs/package.json +++ b/packages/sitecore-jss-nextjs/package.json @@ -14,8 +14,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-nextjs --entryPoints src/index.ts --entryPoints src/monitoring/index.ts --entryPoints src/editing/index.ts --entryPoints src/middleware/index.ts --entryPoints src/context/index.ts --entryPoints src/utils/index.ts --entryPoints src/site/index.ts --entryPoints src/graphql/index.ts --entryPoints src/revalidate/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-proxy/package.json b/packages/sitecore-jss-proxy/package.json index 6987614e12..1b2de24689 100644 --- a/packages/sitecore-jss-proxy/package.json +++ b/packages/sitecore-jss-proxy/package.json @@ -15,8 +15,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-proxy src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-react-forms/package.json b/packages/sitecore-jss-react-forms/package.json index c1dd187e31..a0510b8f46 100644 --- a/packages/sitecore-jss-react-forms/package.json +++ b/packages/sitecore-jss-react-forms/package.json @@ -14,8 +14,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-forms src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-react-native/package.json b/packages/sitecore-jss-react-native/package.json index 9a25a2c2c8..321370acbd 100644 --- a/packages/sitecore-jss-react-native/package.json +++ b/packages/sitecore-jss-react-native/package.json @@ -15,8 +15,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-react-native src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-react/package.json b/packages/sitecore-jss-react/package.json index e14e748c94..c25d8a89f9 100644 --- a/packages/sitecore-jss-react/package.json +++ b/packages/sitecore-jss-react/package.json @@ -14,8 +14,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-react src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-rendering-host/package.json b/packages/sitecore-jss-rendering-host/package.json index 6fe2f556a7..50702b02af 100644 --- a/packages/sitecore-jss-rendering-host/package.json +++ b/packages/sitecore-jss-rendering-host/package.json @@ -14,8 +14,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-rendering-host src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss-vue/package.json b/packages/sitecore-jss-vue/package.json index 3bb54efeac..6a0d76274f 100644 --- a/packages/sitecore-jss-vue/package.json +++ b/packages/sitecore-jss-vue/package.json @@ -15,8 +15,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss-vue src/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", diff --git a/packages/sitecore-jss/package.json b/packages/sitecore-jss/package.json index daff167ee0..992165fb52 100644 --- a/packages/sitecore-jss/package.json +++ b/packages/sitecore-jss/package.json @@ -14,8 +14,7 @@ "generate-docs": "npx typedoc --plugin typedoc-plugin-markdown --readme none --out ../../ref-docs/sitecore-jss --entryPoints src/index.ts --entryPoints src/graphql/index.ts --entryPoints src/i18n/index.ts --entryPoints src/layout/index.ts --entryPoints src/media/index.ts --entryPoints src/personalize/index.ts --entryPoints src/site/index.ts --entryPoints src/tracking/index.ts --entryPoints src/utils/index.ts --githubPages false" }, "engines": { - "node": ">=18", - "npm": ">=10" + "node": ">=18" }, "author": { "name": "Sitecore Corporation", From 21660f25879f8685a1e01661111fb33203dc5ca0 Mon Sep 17 00:00:00 2001 From: illiakovalenko Date: Fri, 15 Dec 2023 17:56:26 +0200 Subject: [PATCH 2/2] Updated CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 18cd8d352c..08060e935c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ Our versioning strategy is as follows: ### ๐Ÿงน Chores * Upgrade to Node.js 20.x ([#1679](https://github.com/Sitecore/jss/pull/1679))([#1681](https://github.com/Sitecore/jss/pull/1681)) +* Removed "npm" field from "engines" property ([#1698](https://github.com/Sitecore/jss/pull/1698)) ### ๐Ÿ› Bug Fixes