Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming of entries #2

Open
solonovamax opened this issue Aug 6, 2020 · 1 comment
Open

Naming of entries #2

solonovamax opened this issue Aug 6, 2020 · 1 comment

Comments

@solonovamax
Copy link

Are the names of these cosmetics directly tied to the names provided by some API?
If not, it is unclear how some cosmetics would be named.

In some shops like the bedwars shop, there are categories like "Projectile Trails", "Victory Dances", "Final Kill Effects", etc. Should a cosmetic like the "Smash" final kill effect be named stats.Bedwars.smash or stats.Bedwars.finalkill.smash?
If you go with the first option, there are some names that would conflict like the "Firework" final kill effect and the "Firework" projectile trail, as both would end up being called stats.Bedwars.firework.

@solonovamax solonovamax changed the title Naming of cosmetics Naming of entries Aug 6, 2020
@solonovamax
Copy link
Author

I propose a naming scheme like this:
All entries for each type are named beginning with stats, followed by the name of the game, followed by the category the entry belongs to in the hypixel shop menu (If it is a part of 2 categories like "Kits & Perks" and "Normal Kits" for the Armorer kit in skywars, only use the most relevant category. It would be "Normal Kits" in this case.), finally followed by the name of the entry. (everything is lower case)
Here are some examples: stats.hungergames.advancedkits.astronaut (unsure why you used "HungerGames" instead of "BlitzSG", so I'm leaving that.), stats.skywars.normalkits.armorer, stats.bedwars.victorydances.dragonrider.

solonovamax added a commit to solonovamax/HypixelNetWorth that referenced this issue Aug 6, 2020
Updated to reflect the naming scheme I proposed in issue Sk1erLLC#2 and the grouping I proposed in issue Sk1erLLC#4.
solonovamax added a commit to solonovamax/HypixelNetWorth that referenced this issue Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant