Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on DEV_MODE don't fail due to broken code #7399

Open
1 task done
ShaneBeee opened this issue Jan 5, 2025 · 0 comments
Open
1 task done

Tests on DEV_MODE don't fail due to broken code #7399

ShaneBeee opened this issue Jan 5, 2025 · 0 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Comments

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Jan 5, 2025

Skript/Server Version

[Skript] Server Version: 1.21.4-72-daddcf6 (MC: 1.21.4)
[Skript] Skript Version: 2.10.0-pre1 (selfbuilt-unknown)
[Skript] Installed Skript Addons: 
[Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[Skript]  - SkBee v3.7.0 (https://github.com/ShaneBeee/SkBee)
[Skript]  - SkBriggy v1.4.3 (https://github.com/ShaneBeee/SkBriggy)
[Skript] Installed dependencies: 
[Skript]  - Vault v1.7.3-b131

Bug Description

When running tests in DEV_MODE, a test does not get marked as failed when syntax is broken:
Screenshot 2025-01-05 at 1 41 40 PM

As you can see here, the test was "successful" (I beg to differ)

Expected Behavior

The test should be marked as failed

Steps to Reproduce

  • spin up dev move gradle skriptTestDev
  • make a mistake in a test, for example in /misc/dummy.sk
  • run said test /sk test /misc/dummy.sk
  • You should now see the "success" right after the failed code
Screenshot 2025-01-05 at 1 44 24 PM

Do note this does fail on quicktest:
Screenshot 2025-01-05 at 1 49 59 PM

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@cheeezburga cheeezburga added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. PR available Issues which have a yet-to-be merged PR resolving it labels Jan 9, 2025
@Romitou Romitou added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.
Projects
None yet
Development

No branches or pull requests

3 participants