Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual itemstack cooldowns #7429

Open
1 task done
ChicknTurtle opened this issue Jan 13, 2025 · 2 comments
Open
1 task done

Individual itemstack cooldowns #7429

ChicknTurtle opened this issue Jan 13, 2025 · 2 comments
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Comments

@ChicknTurtle
Copy link

ChicknTurtle commented Jan 13, 2025

Skript/Server Version

[10:17:10 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[10:17:10 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[10:17:10 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[10:17:10 INFO]: [Skript] Server Version: 1.21.4-100-86c6308 (MC: 1.21.4)
[10:17:10 INFO]: [Skript] Skript Version: 2.9.5 (skriptlang-github)
[10:17:10 INFO]: [Skript] Installed Skript Addons: 
[10:17:10 INFO]: [Skript]  - skript-placeholders v1.7.0 (https://github.com/APickledWalrus/skript-placeholders)
[10:17:10 INFO]: [Skript]  - DiSky v4.21.0
[10:17:10 INFO]: [Skript]  - skript-yaml v1.5
[10:17:10 INFO]: [Skript]  - skript-reflect v2.5.1 (https://github.com/SkriptLang/skript-reflect)
[10:17:10 INFO]: [Skript]  - SkBee v3.6.6 (https://github.com/SkriptHub/SkBee)
[10:17:10 INFO]: [Skript]  - SkBriggy v1.4.3 (https://github.com/ShaneBeee/SkBriggy)
[10:17:10 INFO]: [Skript] Installed dependencies: None

Bug Description

Item Cooldown expression
Use cooldown nbt
It is impossible to set item cooldown using the new cooldown group nbt with skript, it always is set for the entire material. You need to use this method instead of the material one:
https://jd.papermc.io/paper/1.21.4/org/bukkit/entity/HumanEntity.html#setCooldown(org.bukkit.inventory.ItemStack,int)

Expected Behavior

When setting cooldown it should respect the cooldown group of the item

Steps to Reproduce

Doesn't work: !set item cooldown of tool for me to 1 second
Works: !me.setCooldown(1 of tool, 20)

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@erenkarakal
Copy link
Member

erenkarakal commented Jan 13, 2025

this is more of a feature request than a bug report, the cooldown data component wasn't a thing when the cooldown expression was added

@erenkarakal erenkarakal added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 13, 2025
@ChicknTurtle
Copy link
Author

I saw it as a bug that it doesn't work how one would expect, but yeah I see how it should be a suggestion

@Moderocky Moderocky changed the title Item cooldown expression doesn't respect cooldown group Individual itemstack cooldowns (Paper only) Jan 13, 2025
@Moderocky Moderocky changed the title Individual itemstack cooldowns (Paper only) Individual itemstack cooldowns Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

No branches or pull requests

2 participants