Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize conversation.notify_users #60

Open
rickmak opened this issue Nov 25, 2016 · 0 comments
Open

Optimize conversation.notify_users #60

rickmak opened this issue Nov 25, 2016 · 0 comments

Comments

@rickmak
Copy link
Member

rickmak commented Nov 25, 2016

https://github.com/SkygearIO/chat/blob/master/chat/conversation.py#L162

here will create many SQL query. Which can be reduced to one
by changing the _publish_record_event to accept array of user and
internal query to get_channels_by_user_ids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickmak