Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with Korean’s translation on Weblate #13

Closed
DDinghoya opened this issue Sep 17, 2022 · 2 comments
Closed

Problems with Korean’s translation on Weblate #13

DDinghoya opened this issue Sep 17, 2022 · 2 comments

Comments

@DDinghoya
Copy link

Dear,

The above issue has been posted to the 3D Splicer community -> Link

Basically the Korean translation was 100% completed on weblate, and there were two problems.

  1. Korean translation was made, but some items (Menu, Settings, etc.) are not reflected as belows sample pictures;
  • Sample_Menu *
    sample_menu

  • Sample_settings *
    sample_settings

Even if I downloaded the language pack from github and applied it manually, it was not reflected.

  1. Some HTML tags disappear after saving the translation on Weblatea as below;
  • Sample _HTML *
    sample_html

I think the problem arises when using a 2 byte character set.

It is hoped that the cause of the problem and improvement will be addressed through this post. :)

Best regards.

@mhdiop
Copy link
Collaborator

mhdiop commented Sep 21, 2022

Dear @DDinghoya,

Thank you for your exhaustive report, we really appreciate it !

Regarding your first remark, it should be noted that not all strings present in the Slicer GUI are currently listed on Weblate, the translation platform. The remaining strings mainly concern:

  • strings which should be marked as translatable and which are not (both in Python and C++ codes)
  • strings that are already marked but are not extracted yet (mainly in Slicer's Python code)

As @pieper mentioned in the linked post, there is an ongoing project that addresses this issue and some of their work in progress may interest you.

  • For translatable strings present in Python codes, a string extractor has been developed.
  • For translatable strings that are not tagged yet, string marking tools are also proposed.

We are currently working on their integration into the internationalization process and should have convincing results shortly. Thus, missing strings should be available for translation.

For your second point, we will investigate it further to see what's causing it.
@lassoan, @pieper, @Adama-WADE are key resources that may help too.

Thank you again for your interests in this project.

Best regards.

@lassoan
Copy link
Collaborator

lassoan commented Oct 19, 2022

Some of this issues are caused by safe-html setting in Weblate that attempted to sanitize translated text of HTML content. This is now disabled (see #14) and so it should be possible to translate text that contain html tags and special characters.

Text that does not appear in translations are generated dynamically from code and they are not marked as translatable. @mhdiop is working on exposing all these strings. This is tracked in #12.

Since these issues are already tracked in other issues, I'm closing this issue now.

@lassoan lassoan closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants