Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UU-Matter can not be placed into item frames. #80

Open
Skizzles opened this issue Oct 30, 2022 · 3 comments
Open

[BUG] UU-Matter can not be placed into item frames. #80

Skizzles opened this issue Oct 30, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Skizzles
Copy link
Contributor

Description (REQUIRED)

UU-Matter seems to block right click due to being use to dye sheep based off what Panda stated in dms.

Steps to reproduce the Issue (REQUIRED)

Place itemframe
Right click with uu-matter

Expected behavior (REQUIRED)

Allow the uu-matter into item frames as it can be used for storage labeling

Server Log

N/A

Environment (REQUIRED)

  • Server Software (Spigot/Paper): Purpur 1758
  • Minecraft version: 1.19.2
  • Slimefun version: 1035
  • LiteXpansion version: 182
@Skizzles Skizzles added the bug Something isn't working label Oct 30, 2022
@Sefiraat
Copy link
Member

@J3fftw1 think we discussed this vaguely before, but I think a class PRd to slimefun or another lib that protects items like this from all destructive actions while retaining other functions like this as I know crysta and networks has a use for it and I’m sure other’s will also

@J3fftw1
Copy link
Contributor

J3fftw1 commented Oct 30, 2022

Jup this been a long standing issue.
Im just thinking of how we can solve this.
Since there is for dye multiple ways to apply it
Sheep
Signs
Some do want to allow sheep, for example slimefun. Forgot the item name.

@Sefiraat
Copy link
Member

We just have a ProtectedSlimefunItem class (or whatever) with ItemHandlers for all these things that stops the action with a quick check for a Boolean that can be overridden by implementing classes as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants