-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update flow "Sign Twitter" to avoid reuse in another session but reuse in currect session #223
Comments
the expiration of access token is very short and signing actually is not a high frequency action for the same user. so I agree to cache the public attestation, but:
because |
@foxgem , do you remeber why IdAttestation has unlimited TTL? what is purpose for that? |
sorry, I don't know. maybe @colourful-land can answer this. |
I am afraid that it can be some security issue if user has unlimited twitter attestation. |
https://community.tokenscript.org/t/what-if-inet-identifer-such-as-twitter-handle-is-sold/492 |
@colourful-land , do we have any benefits because of unlimited IDattestation? do you remeber why we don't limit IDattestation with expiration? |
As @colourful-land mention in the #203 , we have to avoid reuse of that flow and ask for single IDAttestations per twitter login session.
My suggestion:
as option: we can sign EIP712 message instead of text string if its supported my most of the wallets. Anyway we use EIP712 for attestation.id attestRequest, so if wallet doesnt support EIP712 when it cant sign attestRequest too :-)
that flow require updates for attestation.id backend and autographnft.io frontend. no need to update smartcontract.
@foxgem , @colourful-land does it make sense?
cc @AW-STJ
The text was updated successfully, but these errors were encountered: