Does Criterion Not Allow Testing Custom Signals?

[lordmichael95]

Does Criterion not allow testing custom signals? I can see in the documentation (https://criterion.readthedocs.io/en/master/starter.html#testing-signals) that at least standard C signals can be tested. But are we allowed to test our own custom signals that we raise?

In my testing, it seems like we are not allowed to test custom signals, in this case TEST_SIGNAL_51. I have defined my test signals in signalHandler.h. Though perhaps the failure of test9 indicates the issue is with my signal handler?

Michaels_Criterion_tests.c:

#include <stdio.h>
#include <stdlib.h>
#include <signal.h>
#include "/home/mlayman/Documents/code/Criterion/include/criterion/criterion.h"            //For Criterion framework
#include "/home/mlayman/Documents/code/Criterion/include/criterion/new/assert.h"
#include "Michaels_Criterion_tests.h"
#include "signalHandler.h"
#include "CASCTimer.h"

//#define SIGUSR1 56          //re-define User Signal 1


struct structOfSignals { 
    int sig50; 
    int sig51; 
    int sig52; 
}; 

int testValue;
struct structOfSignals sigs;

void setup6(void) {
    testValue = TEST_SIGNAL_51;
    
    //sigs.sig50 = TEST_SIGNAL_50;
    //sigs.sig51 = TEST_SIGNAL_51;
    //sigs.sig52 = TEST_SIGNAL_52;

    //Register the signal handler
    signal(testValue, sigHandler);

}

void setup7(void) {
    //Redefining SIGUSR1 only for the purposes of this test
    //#define SIGUSR1 TEST_SIGNAL_51     //re-define User Signal 1
    testValue = SIGUSR1;
    
    //sigs.sig50 = TEST_SIGNAL_50;
    //sigs.sig51 = TEST_SIGNAL_51;
    //sigs.sig52 = TEST_SIGNAL_52;

    //Register the signal handler
    signal(testValue, sigHandler);

}

Test(suite1, test7, .init = setup6, .signal = TEST_SIGNAL_51) {
    cr_expect(eq(int, raise(TEST_SIGNAL_51), 0));   //In theory, since the signal gets registered, this should pass. However, Criterion does not seem to recognize custom signals and thus will cause this test to fail.
}

Test(suite1, test8, .init = setup6, .signal = SIGUSR1) {
    cr_expect(eq(int, raise(SIGUSR1), 0));   //Pass, SIGUSR1 is a standard C signal.
}

Test(suite1, test9, .init = setup7, .signal = SIGUSR1) {
    cr_expect(eq(int, raise(SIGUSR1), 0));   //Fail, because I am registering SIGUSR1 to my signal handler??? Or some other reason?
}

Michaels_Criterion_tests.h:

#ifndef MICHALES_CRITERION_TEST_H
#define MICHALES_CRITERION_TEST_H

//Function declarations
void setup(void);
void teardown(void);
void setup2(void);
void setup3(void);
void setup4(void);
void setup5(void);
void setup6(void);
void setup7(void);

#endif /* MICHALES_CRITERION_TEST_H */

signalHandler.c:

#include <stdio.h>
#include <stdlib.h>
#include <signal.h>
#include "signalHandler.h"


//sig_atomic_t signaled = 0;      //Debug testing only. Remove later.

/************************************************************************************************************
The function is a signal handler.
Parameters:
    int sig - The signal's number
Returns:
    N/A
************************************************************************************************************/
void sigHandler(int sig)
{
    //signaled = 1;

    //Switch statement to handle all signals
    switch(sig) {
        case TEST_SIGNAL_50:
            printf("Case 50 has been matched.\n");
            //LOG AND DO STUFF...
            break;
        case TEST_SIGNAL_51:
            printf("Case 51 has been matched.\n");
            //LOG AND DO STUFF...
            break;
        case TEST_SIGNAL_52:
            printf("Case 52 has been matched.\n");
            //LOG AND DO STUFF...
            break;
        case SIGINT:
            printf("SIGINT Case has been matched.\n");
            //LOG AND DO STUFF...
            break;
        default:    //Raised signal is not a match
            printf("Raised signal %d is not a match.\n", sig);
            //Probably just log an error and hope we can ignore without blowing up??
            break;
    }
}

signalHandler.h:

#ifndef SIGNAL_HANDLER_H
#define SIGNAL_HANDLER_H

#define TEST_SIGNAL_50 50       //PLACEHOLDER
#define TEST_SIGNAL_51 51       //PLACEHOLDER
#define TEST_SIGNAL_52 52       //PLACEHOLDER


//Function declarations
void sigHandler(int sig);

#endif /* SIGNAL_HANDLER_H */

EDIT

Here is my makefile:
makefile:

#To build the test files:
#make BUILD_TYPE=test
#To build the production files:
#make
#To get ride of all object and production executable files:
#make clean

#Compiler command - gcc for C; g++ for C++
CC = gcc
#Compiler flags
CFLAGS = -Wall -Wextra -g
#Location of the Criterion library
LDFLAGS = -L~/Documents/code/Criterion/include
#Name/Linking to the Criterion library
LDLIBS = -lcriterion

#Source files
PRODUCTION_SRCS = main.c CASCTimer.c signalHandler.c
TEST_SRCS = Michaels_Criterion_tests.c CASCTimer.c signalHandler.c

#If BUILD_TYPE = "test", use test files; else, use production files
ifeq ($(BUILD_TYPE), test)
    SRCS = $(TEST_SRCS)
    TARGET = testProgram
else
    SRCS = $(PRODUCTION_SRCS)
    TARGET = productionProgram
endif

#Object files
OBJS = $(SRCS:.c=.o)

#Specifies that "all" and "clean" are not actual files
.PHONY: all clean

all: $(TARGET)

$(TARGET): $(OBJS)
	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LDLIBS)

%.o: %.c
	$(CC) $(CFLAGS) -c -o $@ $<

clean:
	$(RM) $(OBJS) $(TARGET)

[Snaipe]

.signal = TEST_SIGNAL_51 means that Criterion should expect the test to be terminated by that signal.

Since you're handling the signal, and the test process isn't dying from said signal, Criterion is marking the test as failed.

[lordmichael95]

Ooohh, okay! I was misunderstanding the purpose of .signal. Thank you so much for that explanation!