Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB, Calendar view: Record about rejected sick leave appears in [dbo].[SickLeaveCancellations] #611

Open
KuchaLeni opened this issue Apr 15, 2019 · 11 comments

Comments

@KuchaLeni
Copy link

  1. Create sick leave
  2. Approve sick leave from step 1 by supervisor
  3. Reject approved sick leave

Result:
Record about rejected sick leave appears in [dbo].[SickLeaveCancellations]

Expected result:
Record about rejected sick leave appears in [dbo].[SickLeaveRejects]

@sponkrashin
Copy link
Contributor

@antonm76 , the same question about request. What do you send to server in that case?

@antonm76
Copy link
Contributor

@YaroTs could you please answer @sponkrashin ?

@YaroTs
Copy link

YaroTs commented Apr 15, 2019

@sponkrashin

PUT  /employees/2237/events/Sickleave_23
{
    "calendarEventId": "Sickleave_23",
    "type": "Sickleave",
    "dates": {
        "startDate": "04/15/2019",
        "endDate": "04/18/2019",
        "startWorkingHour": 0,
        "finishWorkingHour": 8
    },
    "status": "Cancelled"
}

@sponkrashin
Copy link
Contributor

This is not correct. Cancelled is when employee cancels it's own event. When event is rejected by supervisor, Rejected status should be sent.

@antonm76
Copy link
Contributor

antonm76 commented Apr 15, 2019

@KuchaLeni @sponkrashin , it is not possible to Reject already approved sick leave, it is only possible to Cancel it. Supervisor could Reject sick leave the very first time it appears, before it was approved by him or another supervisor.
It is by design, so please tell us what proper behaviour should be.

@KuchaLeni
Copy link
Author

Supervisor has the possibility to reject already approved sick leave on employee's profile.
image

@sponkrashin
Copy link
Contributor

Ok, we are tangled in terms. I'll ask @santee.

@antonm76
Copy link
Contributor

@KuchaLeni "Discard" in this particular case means "Cancelled" status of an event. It was designed this way originally, but I'm not 100% sure it is correct.

@antonm76
Copy link
Contributor

Evernote Snapshot 20190204 185029

@antonm76
Copy link
Contributor

According to the table of states I attached, approved events can only be cancelled.

@sponkrashin
Copy link
Contributor

@santee has just said that it doesn't really matter for now. He said it another way, not so politeness, but his words had such meaning. So let's postpone this and keep it as is now.

@sponkrashin sponkrashin modified the milestones: Alpha start, Beta start Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants