Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new report spec needs fixes #308

Open
wholmgren opened this issue Dec 10, 2020 · 1 comment
Open

create new report spec needs fixes #308

wholmgren opened this issue Dec 10, 2020 · 1 comment

Comments

@wholmgren
Copy link
Member

"normalization" is a valid key for elements of "object_pairs", right? It's included in core's reports tests here and here

{
  "report_parameters": {
    "categories": [
      "total"
    ],
    "costs": null,
    "end": "2019-08-24T14:15:22Z",
    "filters": null,
    "forecast_fill_method": null,
    "metrics": [
      "mae"
    ],
    "name": "string",
    "object_pairs": [
      {
        "aggregate": "0f59de55-2f0e-436a-8ea9-fb197b396fd3",
        "cost": null,
        "forecast": "c1058bd0-c3da-4141-92c6-496be27f264d",
        "forecast_type": "forecast",
        "observation": "5bf24aaf-36fe-45d8-956d-da6551803aa4",
        "reference_forecast": null,
        "uncertainty": null
      }
    ],
    "start": "2019-08-24T14:15:22Z"
  }
}
@wholmgren wholmgren changed the title add normalization to create new report spec create new report spec needs fixes Dec 10, 2020
@wholmgren
Copy link
Member Author

wholmgren commented Dec 10, 2020

longer list of potential issues with the create new report example json and/or docstring:

  • no normalization spec/docs
  • filter spec example would be helpful
  • cost spec example would be helpful
  • forecast fill method not fully documented
  • should add nmae and skill to example metrics, reference forecast uuid
  • includes both an aggregate and an observation uuid, and docs don't address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant