Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature coefficient units #11

Open
williamhobbs opened this issue Nov 4, 2021 · 4 comments
Open

Temperature coefficient units #11

williamhobbs opened this issue Nov 4, 2021 · 4 comments

Comments

@williamhobbs
Copy link

solarforecastarbiter.datamodel.PVModelingParameters takes in temperature_coefficient in units of %/C, while the temperature coefficients used in pvlib, typically gamma_pdc, are in units of 1/C. Additionally, the example from the workshop is in units of 1/C:

temperature_coefficient=-0.003, # 1/C

Is there a reason that the units are different in solarforecastarbiter?

@williamhobbs
Copy link
Author

I just remembered that the units for site metadata in the web interface are %/C, and I was probably involved in that decision, or at least had the opportunity to comment on it...

@lboeman
Copy link
Member

lboeman commented Nov 4, 2021

It looks like we neglected to update the workshop notebook with new values after adjusting the units. Thanks for bringing it to our attention. I know that the API documentation for these units was not updated until long after this change was implemented in the core library and dashboard.

The primary motivations for this change were that AC and DC loss factor are specified in units of % and temperature coefficients are typically available on datasheets in units of %/C as discussed here: SolarArbiter/solarforecastarbiter-core#350

Conversion to units of 1/C for use in pvlib occurs in the calculate_power function: https://github.com/SolarArbiter/solarforecastarbiter-core/blob/25fc4c97114f9750d9e1381cddbc783e7024e662/solarforecastarbiter/pvmodel.py#L270

@williamhobbs
Copy link
Author

The reasoning behind using %/C makes sense to me.

Thanks.

@wholmgren
Copy link
Member

I am certain this came out of the DOE workshop in October 2019 in DC, and I recall you had some good suggestions there...

I'll transfer the issue to the workshop repository so we don't forget to update the notebook.

@wholmgren wholmgren transferred this issue from SolarArbiter/solarforecastarbiter-core Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants