Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more integration tests #1050

Open
frankduncan opened this issue Aug 24, 2018 · 2 comments
Open

Add more integration tests #1050

frankduncan opened this issue Aug 24, 2018 · 2 comments

Comments

@frankduncan
Copy link

This is a catchall issue for generally adding more integration tests. The current codebase has some tests, but could use more to get it to a point where most use cases are at least touched, if not thoroughly explored. For PRs that need groundwork laid for this, this issue can be used.

@frankduncan
Copy link
Author

Related to #752

@frankduncan
Copy link
Author

Related to #997 (comment)

frankduncan pushed a commit that referenced this issue Aug 24, 2018
Issue #1050: Add more integration tests
jasonaowen added a commit that referenced this issue Aug 24, 2018
The DMF API in the cavetl repo is difficult to set up, mostly because it
requires special access and permissions and so on. For the sake of
demos, and to ease testing the PSM side of the DMF integration, add some
test data and document how to use it.

We want this mock data in the PSM repository and not in the CAVETL
repository for a few reasons:

- this is, like the code that consumes the DMF API, documentation of
  what the PSM expects
- these mocks are useful for testing and demonstrating the PSM
- these mocks are useful for writing integration tests
- the PSM's dependency on CAVETL does not include explicit version
  numbers or commit hashes, and if the DMF API implementation in the
  CAVETL repo changes, the PSM should be able to fall back to these
  mocks until it is updated to consume the new API (and these mocks
  should be updated to match)
- as a side effect of the previous point, it may be useful to be able to
  go back in time to previous versions of the PSM, and having these
  mocks eases that

Thanks to Frank for sharing the special SSNs and names returned by the
Veris Test API.

Issue #759 Automatically check SSN against the Death Master File
Issue #1050 Add more integration tests

Co-authored-by: Frank Duncan <[email protected]>
jasonaowen added a commit that referenced this issue Aug 24, 2018
The DMF API in the cavetl repo is difficult to set up, mostly because it
requires special access and permissions and so on. For the sake of
demos, and to ease testing the PSM side of the DMF integration, add some
test data and document how to use it.

We want this mock data in the PSM repository and not in the CAVETL
repository for a few reasons:

- this is, like the code that consumes the DMF API, documentation of
  what the PSM expects
- these mocks are useful for testing and demonstrating the PSM
- these mocks are useful for writing integration tests
- the PSM's dependency on CAVETL does not include explicit version
  numbers or commit hashes, and if the DMF API implementation in the
  CAVETL repo changes, the PSM should be able to fall back to these
  mocks until it is updated to consume the new API (and these mocks
  should be updated to match)
- as a side effect of the previous point, it may be useful to be able to
  go back in time to previous versions of the PSM, and having these
  mocks eases that

Thanks to Frank for sharing the special SSNs and names returned by the
Veris Test API.

Issue #759 Automatically check SSN against the Death Master File
Issue #1050 Add more integration tests

Co-authored-by: Frank Duncan <[email protected]>
frankduncan pushed a commit that referenced this issue Aug 25, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 26, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 26, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 26, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 26, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 28, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Aug 29, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests #1050
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 7, 2018
Issue #1050: Add more integration tests
PaulMorris pushed a commit that referenced this issue Sep 18, 2018
Issue #1050: Add more integration tests
PaulMorris pushed a commit that referenced this issue Sep 18, 2018
Issue #1050: Add more integration tests #1050
PaulMorris pushed a commit that referenced this issue Sep 18, 2018
Issue #1050: Add more integration tests
PaulMorris pushed a commit that referenced this issue Sep 18, 2018
Issue #1050: Add more integration tests
frankduncan pushed a commit that referenced this issue Sep 27, 2018
When adding #1050: Add integration tests, the hibernate sequence
was updated, but the changeset was changed so that existing databases
would not get the new sequence.  This updates to allow any changsets.
frankduncan pushed a commit that referenced this issue Sep 27, 2018
When mergin #1052 to add integration tests, the hibernate sequence
was updated, but the changeset was changed so that existing databases
would not get the new sequence.  This updates to allow any changsets.

Related to Issue #1050: Add integration tests
frankduncan pushed a commit that referenced this issue Sep 27, 2018
When merging #1052 to add integration tests, the hibernate sequence
was updated, but the changeset was changed so that existing databases
would not get the new sequence.  This updates to allow any changsets.

Related to Issue #1050: Add integration tests
frankduncan pushed a commit that referenced this issue Sep 27, 2018
When merging #1052 to add integration tests, the hibernate sequence
was updated, but the changeset was changed so that existing databases
would not get the new sequence.  This updates to allow any changesets.

Related to Issue #1050: Add integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants