Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonix qmk hator gravity tkl #425

Open
wants to merge 15 commits into
base: sn32_develop
Choose a base branch
from
Open

Sonix qmk hator gravity tkl #425

wants to merge 15 commits into from
+1 −6

Conversation

Matros1975
Copy link

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Matros1975 Matros1975 marked this pull request as draft September 25, 2024 07:19
@Matros1975 Matros1975 marked this pull request as ready for review September 25, 2024 07:45
dexter93
dexter93 requested changes Sep 26, 2024
View reviewed changes
Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no chance this builds, let alone work.

Please rebase, read this https://sonixqmk.github.io/qmk_docs/drivers/sn32f2xx#basic-configuration and test before submitting.

@Matros1975 Matros1975 marked this pull request as draft October 4, 2024 07:11
@Matros1975 Matros1975 marked this pull request as ready for review October 4, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter93 dexter93 dexter93 requested changes

Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matros1975 @dexter93