Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-Python for Half-life 2 Deathmatch #500

Open
Lunacy1984 opened this issue Nov 23, 2024 · 41 comments
Open

Source-Python for Half-life 2 Deathmatch #500

Lunacy1984 opened this issue Nov 23, 2024 · 41 comments

Comments

@Lunacy1984
Copy link

In regards to support for Half-life 2 Deathmatch.
As of November 17 2024 with the 20th anniversary update this plugin will no longer work on a half-life 2 deathmatch server. With no other plugins or addons installed Source-Python will cause the server to crash. A good number of severs need python to use addons.

@Ayuto
Copy link
Member

Ayuto commented Nov 23, 2024

Thanks for reporting! Unfortunately, I can't provide an official fix at the moment as I don't have access to our build system until the 2nd of December. I will then provide a fix.

@Lunacy1984
Copy link
Author

Thankyou. I figured this would take some time. It will hopefully give Valve enough time to finish unexpected patches they seem to be putting out every other day. I am trying to rewrite some scrips for my server in the mean time with sourcemod.

@LsLoki
Copy link

LsLoki commented Nov 27, 2024

Thanks for reporting! Unfortunately, I can't provide an official fix at the moment as I don't have access to our build system until the 2nd of December. I will then provide a fix.

Great news, thank you for that commitment to fix SP for HL2DM. Can you please investigate the impact on your EventScripts Emulator too. I am assuming it is not working given Matties EventScripts is currently broken.

@Lunacy1984
Copy link
Author

Great news, thank you for that commitment to fix SP for HL2DM. Can you please investigate the impact on your EventScripts Emulator too. I am assuming it is not working given Matties EventScripts is currently broken.

That's what I was hoping for too is the Eventscripts. Brand New for 1979 still runs a great deal of visual effects with Eventscripts and Python. Largely obsolete, but I don't know how to write it for Sourcemod.

@Lunacy1984
Copy link
Author

Any update so far or just trying to make sense of the valve updates?

@LsLoki
Copy link

LsLoki commented Dec 6, 2024

Why is this closed?

@Lunacy1984 Lunacy1984 reopened this Dec 6, 2024
@Lunacy1984
Copy link
Author

User interface issue. NOT CLOSED by any means

@Ayuto
Copy link
Member

Ayuto commented Dec 7, 2024

Sorry for the delay. It has been a busy week. A new build is now available. Though, HL2DM requires new signatures on Windows. This is still an open ToDo.

@Lunacy1984
Copy link
Author

I hear you. I have hardly had time for my server stuff with the push for the holidays.

@Lunacy1984
Copy link
Author

So not ready for HL2DM yet. Thought I saw quick fix for hl2dm.

@Ayuto
Copy link
Member

Ayuto commented Dec 10, 2024

Linux should be fine. Windows will crash unless you disable the entities listener.

@jordanbriere
Copy link
Contributor

So not ready for HL2DM yet. Thought I saw quick fix for hl2dm.

Based on your previous post (that you appear to have now deleted), I suspect that you downloaded the source code from here rather than the latest release from there: http://downloads.sourcepython.com/

Linux should be fine. Windows will crash unless you disable the entities listener.

Our signature to gEntList was still valid and the signature of CBaseEntityOutput::FireOutput has been updated.

@Lunacy1984
Copy link
Author

I deleted a comment since I saw my own error

@LsLoki
Copy link

LsLoki commented Dec 14, 2024

Linux should be fine. Windows will crash unless you disable the entities listener.

Can you please update this thread when you have updated for Windows. Many Thanks.

@Ayuto
Copy link
Member

Ayuto commented Dec 14, 2024

Signatures have been updated 4 days ago. So, if the auto update is enabled, it should work already. This morning I also started a new build that also includes the updated signature. Please try again and let us know if it's working for you.

@LsLoki
Copy link

LsLoki commented Dec 14, 2024

Signatures have been updated 4 days ago. So, if the auto update is enabled, it should work already. This morning I also started a new build that also includes the updated signature. Please try again and let us know if it's working for you.

Version 724 works a treat on Windows. Will test with Linux later. Thank you very much!

@Lunacy1984
Copy link
Author

I saw a loaded successfully, but I did have a crash before I could get in. Making sure that there is not a conflict issue with Source-metamod, sourcemod, and Hurricane bots.

@Lunacy1984
Copy link
Author

Still a crash on joining. The server will sit running until I try to join.

No other plugins running on a Source Dedicated server at my home on Windows 11.
Most recent release of your download. Console log with Sourcemod calls removed since that plugin is disabled.

[Source.Python] Loading...
[Source.Python]
[SP] Encountered a Warning:
File '..\addons\source-python\packages\site-packages\mutagen\id3_specs.py', line 666: DeprecationWarning
invalid escape sequence \s

[Source.Python] Loaded successfully.
maxplayers set to 16
maxplayers set to 16
Network: IP 192.168.1.104, mode MP, dedicated Yes, ports 27015 SV / 27005 CL
CMaterialSystem::ReloadMaterials bDeviceReady false
Using map cycle file 'mapcycle.txt'. ('cfg\mapcycle.txt' was not found.)
Error loading cfg/vscript_convar_allowlist.txt
VSCRIPT: Started VScript virtual machine using script language 'Squirrel'
Script not found (scripts/vscripts/mapspawn.nut)
Precache of sprites/redglow1 ambigious (no extension specified)
Precache of sprites/redglow1 ambigious (no extension specified)
Precache of sprites/redglow1 ambigious (no extension specified)
Precache of sprites/redglow1 ambigious (no extension specified)
Set motd from file 'motd.txt'. ('cfg/motd.txt' was not found.)
Set motd_text from file 'cfg/motd_text_default.txt'. ('cfg/motd_text.txt' was not found.)
SV_ActivateServer: setting tickrate to 33.0
Writing cfg/banned_user.cfg.
Writing cfg/banned_ip.cfg.


sv_pure value unchanged (current value is 0).

Server is hibernating
Client "[PCP] Lunacy [1979] ☠" connected (192.168.1.7:27005).
Server waking up from hibernation

@LsLoki
Copy link

LsLoki commented Dec 14, 2024

Signatures have been updated 4 days ago. So, if the auto update is enabled, it should work already. This morning I also started a new build that also includes the updated signature. Please try again and let us know if it's working for you.

Version 724 works a treat on Windows. Will test with Linux later. Thank you very much!

Yes same here, seems I spoke too soon. Version 724 loads fine and appears stable, loads the es emulator. But players are unable to join, the server does not crash it just hangs. Eliminated any conflict with SM or MM, tried with es emulator off, and any other SP plugins disabled. Only error in the log,

Error loading cfg/vscript_convar_allowlist.txt
VSCRIPT: Started VScript virtual machine using script language 'Squirrel'
Script not found (scripts/vscripts/mapspawn.nut)

Problem resolved for players joining the server, by disabling Source Python.

@Lunacy1984
Copy link
Author

Also of note from recording a video of only the base source-python and nothing else running.
This crash is not written in the log

Unable to find return address. You are going to crash now.
src\tier0\threadtools.cpp (3465) : Assertion Failed: Illegal termination of worker thread 'CFileWriterThread'
src\tier0\threadtools.cpp (3465) : Assertion Failed: Illegal termination of worker thread 'CFileWriterThread'

@CookStar
Copy link
Contributor

Since vtable has changed, that doesn't surprise me.

CookStar added a commit to CookStar/Source.Python that referenced this issue Dec 15, 2024
@CookStar
Copy link
Contributor

This should solve the problem with SP data. #502

@LsLoki
Copy link

LsLoki commented Dec 15, 2024

This should solve the problem with SP data. #502

Indeed that allowed me to join the server again with SP v724 running. Thank you very much for detailing those revised offsets. I will do more testing.

@Lunacy1984
Copy link
Author

Damn. I tried with this latest update and I was unable to join a fresh server with only the base source.python installed. Don't know what is left to eliminate.

[Source.Python] Loading...
[Source.Python] Loaded successfully.
maxplayers set to 16
maxplayers set to 16
Unknown command "autoupdate"
Unknown command "port"
Network: IP 192.168.1.104, mode MP, dedicated Yes, ports 27017 SV / 27005 CL
CMaterialSystem::ReloadMaterials bDeviceReady false
Using map cycle file 'cfg/mapcycle_default.txt'. ('cfg\mapcycle.txt' was not found.)
Error loading cfg/vscript_convar_allowlist.txt
VSCRIPT: Started VScript virtual machine using script language 'Squirrel'
Script not found (scripts/vscripts/mapspawn.nut)
Precache of sprites/redglow1 ambigious (no extension specified)
Precache of sprites/redglow1 ambigious (no extension specified)
Set motd from file 'cfg/motd_default.txt'. ('cfg/motd.txt' was not found.)
Set motd_text from file 'cfg/motd_text_default.txt'. ('cfg/motd_text.txt' was not found.)
SV_ActivateServer: setting tickrate to 33.0
'server.cfg' not present; not executing.
Server is hibernating
Client "[PCP] Lunacy [1979] ☠" connected (192.168.1.7:27005).
Server waking up from hibernation

@CookStar
Copy link
Contributor

Damn. I tried with this latest update and I was unable to join a fresh server with only the base source.python installed. Don't know what is left to eliminate.

Have you tried #502?

@Lunacy1984
Copy link
Author

Thought I downloaded the one on the main page that was stated as updated. I will try it again when I am able.

@Lunacy1984
Copy link
Author

I got in for a second before it crashed. I will reload it again when I get home.

@Lunacy1984
Copy link
Author

Might be onto something now
Source-python has loaded along with metamod source, sourcemod, and I also have it working with bots. Now I just have to figure out the ES emulator

@CookStar
Copy link
Contributor

You will have to download it from here as it is not yet merged.
https://github.com/CookStar/Source.Python/tree/hl2mp_v

Overwrite what is in the folder here.
https://github.com/CookStar/Source.Python/tree/hl2mp_v/addons/source-python/data/source-python/entities/orangebox/hl2mp

@CookStar
Copy link
Contributor

I cannot guarantee that Source-Python-Dev-Team will merge my pull request, so please do it yourself.

@Lunacy1984
Copy link
Author

Dumb question, could someone point me to where I can add more plugins. I found tutorials and forums, but I can't find where I got the ES Emulator from.

@CookStar
Copy link
Contributor

Dumb question, could someone point me to where I can add more plugins. I found tutorials and forums, but I can't find where I got the ES Emulator from.

https://github.com/Ayuto/EventScripts-Emulator

@Lunacy1984
Copy link
Author

I have that page, but I thought I found other source-python plugins. That is what I am looking for.

@CookStar
Copy link
Contributor

I don't know which source-python plugins you are talking about.

@Lunacy1984
Copy link
Author

ES_emulater is only one of the plugins that you can add to source-python. I know I saw more

@CookStar
Copy link
Contributor

You mean you don't know how to install the plugin for Source.Python? I am not sure what you are asking.

@Lunacy1984
Copy link
Author

1 Source-python is installed and running
2 ES emulator is installed and working
3 LOOKING FOR MORE PLUGINS that are for source-python like you would add to sourcemod for example

@CookStar
Copy link
Contributor

I've never installed someone else's plugin, so I don't know, but you might want to check the forums or ask on the forum.

Ayuto pushed a commit that referenced this issue Dec 17, 2024
@Ayuto
Copy link
Member

Ayuto commented Dec 17, 2024

Beside the links @CookStar provided you can also look for repositories tagged with source-python here on GitHub.

I never really published the ES emulator officially. I just created the repository as a fun project. But the interest was bigger than expected.

@CookStar
Copy link
Contributor

Hey @Ayuto, this is not the right place to say this, but could you please take a look at the pull requests that have not received any replies at all? (#496, #499, #501)

@Ayuto
Copy link
Member

Ayuto commented Dec 17, 2024

Yeah, I'm sorry... I haven't really had time to have a proper look at the issues you fixed with the PRs. Hopefully, that will change in mid of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants