Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests for mandatory-flavor-list (#319) #339

Closed
2 tasks
garloff opened this issue Aug 30, 2023 · 1 comment · Fixed by #438
Closed
2 tasks

CI tests for mandatory-flavor-list (#319) #339

garloff opened this issue Aug 30, 2023 · 1 comment · Fixed by #438
Assignees
Labels
IaaS Issues or pull requests relevant for Team1: IaaS SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10

Comments

@garloff
Copy link
Contributor

garloff commented Aug 30, 2023

With PR #319, we move away from the compressed form of listing mandatory and recommended SCS flavors to a more verbose format. While the compressed form only used SCS names and derived all properties from them, the new format lists all the properties, including the name as name and then also as extra_spec scs:name-v1 and scs:name-v2.
https://github.com/SovereignCloudStack/standards/blob/issue/267/Tests/iaas/scs-0103-v1-flavors.yaml
This is more easy to read and also makes us less dependent on the names.
However, we have the same information twice now, once implicit in the name and once as explicit properties.
The risk is to have these diverge, creating inconsistencies that are embarassing for us and painful for operators and their customers. We need to avoid this.
TASKS:

  • Use the existing code base to create a check for the consistency of scs-0103-v1-flavors.yaml file
  • Run this code as a CI check, so we never merge a broken 0103-flavors file.
@mbuechse
Copy link
Contributor

mbuechse commented Aug 31, 2023

First of all, I'm not sure if the list of mandatory flavors will change very much. @frosty-geek already told me he didn't want that to happen at all.

Besides, if the list did change, we would make sure that the reference implementation wouldn't lose its certification. Which should preclude the divergence between name and properties, as long as the test for scs-0001 check that the properties match the name. To this end, this test SHOULD be extended to check the extra_specs. I think this would be much more pressing than the CI check.

@mbuechse mbuechse added IaaS Issues or pull requests relevant for Team1: IaaS SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10 labels Sep 25, 2023
@mbuechse mbuechse self-assigned this Dec 21, 2023
mbuechse added a commit that referenced this issue Dec 22, 2023
mbuechse added a commit that referenced this issue Jan 8, 2024
@anjastrunk anjastrunk mentioned this issue Apr 15, 2024
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IaaS Issues or pull requests relevant for Team1: IaaS SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants