Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Implement plugin for cluster-stacks #774

Open
tonifinger opened this issue Oct 9, 2024 · 5 comments · May be fixed by #800
Open

[Feature Request] Implement plugin for cluster-stacks #774

tonifinger opened this issue Oct 9, 2024 · 5 comments · May be fixed by #800
Assignees
Labels
enhancement New feature or request SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10

Comments

@tonifinger
Copy link
Contributor

Based on #710, a plugin must be added that creates k8s clusters with the usage of cluster-stacks

To do this, we need to derive a plugin from Tests/kaas/plugin/interface.py that implements the following two methods:

The current plugin implementation from kind can be used as an example: Tests/kaas/plugin/plugin_kind.py

@tonifinger tonifinger added enhancement New feature or request Container Issues or pull requests relevant for Team 2: Container Infra and Tooling SCS-VP10 Related to tender lot SCS-VP10 SCS is standardized SCS is standardized and removed Container Issues or pull requests relevant for Team 2: Container Infra and Tooling labels Oct 9, 2024
@michal-gubricky michal-gubricky linked a pull request Nov 2, 2024 that will close this issue
@michal-gubricky
Copy link
Contributor

Summary of Work Done on Issue #774 (In Progress):

  • Investigation: Reviewed requirements and related issue #710 to understand the necessary steps for implementation.
  • Plugin Implementation: Developed the cluster-stacks plugin by deriving it from Tests/kaas/plugin/interface.py, implementing the _create_cluster and _delete_cluster methods, and pushed the initial commit to a branch.
  • Cluster Deployment: Deployed a Kubernetes cluster using the cluster-stacks plugin and verified the functionality.
  • Cluster Deletion: Successfully deleted the created cluster-stack cluster.
  • Testing: Conducted tests to validate the creation and deletion of the Kubernetes cluster using the cluster-stacks plugin on the GX-SCS infrastructure.
  • Code Refactoring: Refactored the code by replacing simple sleep statements with wait definitions for CSO and CAPI pods to improve reliability.
  • Adaptation: Made necessary adaptations to the cluster-stacks plugin based on changes in the branch 710-feature-request-enable-compliance-tests-to-use-plugins-for-cluster-provisioning.
  • Draft PR: Created a draft pull request to initiate the review process for the implemented plugin.

@mbuechse mbuechse linked a pull request Nov 4, 2024 that will close this issue
@mbuechse
Copy link
Contributor

mbuechse commented Nov 4, 2024

@michal-gubricky Thanks for the comprehensive update. You're saying it's still in progress. Would you like to have feedback now, or when would you expect to reach a point where feedback could be given?

@michal-gubricky
Copy link
Contributor

@michal-gubricky Thanks for the comprehensive update. You're saying it's still in progress. Would you like to have feedback now, or when would you expect to reach a point where feedback could be given?

Hi, I will ping you for feedback and a review because I am currently adjusting my original code based on the changes made in this branch.

@mbuechse
Copy link
Contributor

mbuechse commented Nov 4, 2024

@michal-gubricky Sounds great. Thank you!

@michal-gubricky
Copy link
Contributor

michal-gubricky commented Nov 6, 2024

Hi @mbuechse, I assigned you as a reviewer to the linked draft PR. The code and README should now be adjusted based on the changes made in the mentioned branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request SCS is standardized SCS is standardized SCS-VP10 Related to tender lot SCS-VP10
Projects
Status: Doing
Development

Successfully merging a pull request may close this issue.

3 participants