Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional tests of spf dependent on live domain TXT records #87

Open
nresare opened this issue Apr 10, 2018 · 0 comments
Open

functional tests of spf dependent on live domain TXT records #87

nresare opened this issue Apr 10, 2018 · 0 comments
Assignees

Comments

@nresare
Copy link
Contributor

nresare commented Apr 10, 2018

Version information

Latest master, 6740c10

Steps to replicate

  1. Run the spf functional tests: PYTHONPATH=. py.test tests/functional/test_plugins/test_spf.py

Actual result

A bunch of failures where SPF_SOFTFAIL is expected but SPF_FAIL is observed

Expected result

No failures

Other notes

There is a repeated pattern in functional/test_plugins/test_spf.py where an SPF lookup is performed for a received line containing an envelope-from <[email protected]>, for the dummy IP 1.2.3.4 as receiving IP. I'm assuming that the TXT record for spamexperts.com that defines it's SPF policy has changed since the test was constructed.

I think that it is fine to do online lookup of actual domain names in functional tests, but it seems unfortunate to do it with a dns name that might change in the future (as illustrated by the spamexperts.com example). I would be happy to set up some records under resare.com (a domain that I have had for almost 20 years now) that exist specifically for this purpose and that wouldn't change over time. A better option might be to create some proper TXT or SPF records under spamexperts.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants