Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild the entire plugin #23

Open
ju5t opened this issue Jul 23, 2021 · 0 comments
Open

Rebuild the entire plugin #23

ju5t opened this issue Jul 23, 2021 · 0 comments

Comments

@ju5t
Copy link
Contributor

ju5t commented Jul 23, 2021

Let's be honest, this plugin hasn't really gotten any real attention for years.

It's insecure (#22) and apart from a new logo, it's hardly maintained. Although there is an issue about verifying PHP 7 compatibility, this was never addressed. On recent versions we get deprecation errors (#19).

I would argue that this plugin needs to be rebuild from the ground up. Preferably not by ModulesGarden. Their code is often riddled with bugs and the quality of their code is low.

@dbistriceanu @LaurentiuTeodorescu @tonyandrewmeyer

Some points of attention:

  • Use a supported version of PHP and keep this up to date.
  • Use a modern approach to use the API (or keep the DirectAdmin class update, even though this class isn't great).
  • Do not use jQuery (especially not 1.10.2.. it's 8 years (!!!) old. Use native JavaScript and AlpineJS for dynamic things.
  • Write tests for all PHP code (with PEST or PHPUnit).
  • Include documentation within the repository or keep it maintained elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant