-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update librespot dependencies #1301
base: master
Are you sure you want to change the base?
Conversation
Thank you for the contribution! I'm a little confused, since in v0.3.5, the librespot version we were using, was already at 0.4.2. So this should not actually change anything. (the version spec See here for one of the |
Confirmation on this, this solves the issues |
Librespot pulled version 0.4 perhaps there some fudging with cargo due to that |
How strictly does |
Spotifyd fails to load encrypted files. This seems to be related to changes on Spotify's end. The librespot v0.4.2 release blacklists a few access points that caused librespot to fail playback anything. This change points the librespot v0.4.2 to address similar issues.
Seeing as the librespot dependencies in Cargo.lock are already on 0.4.2 and running In my quick test this still solves the problem, but has a better chance of passing the CI. |
Have you tried compiling the current master without the |
Spotifyd fails to load encrypted files. This seems to be related to changes on Spotify's end. The librespot v0.4.2 release blacklists a few access points that caused librespot to fail playback anything. This change points the librespot v0.4.2 to address similar issues.
Fixes #1300 and #1299.
Note: I'm not a Rust developer, I'm not sure if the changes to Cargo.lock are really necessary. All I did was a
cargo update
after modifying the Cargo.toml.