Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading Error Message when Route53 DelegationSet is full, and a new domain is added #2962

Open
hallorans-nca opened this issue May 17, 2024 · 1 comment

Comments

@hallorans-nca
Copy link

Describe the bug
If a Route53 DelegationSet is full, and another domain tries to be added, the error message you receive does not return the root cause of the error

To Reproduce
Steps to reproduce the behavior:

  1. Create DelegationSet, and populate with 100 domains (The default limit, but this can be increased)
  2. Run dnscontrol preview
  3. Confirm the message about 'will be added automatically' is present
  4. Run dnscontrol push
  5. See Error about 'error while getting Nameservers'

Preview

ROUTE53 DelegationSet N.....M configured
******************** Domain: zzzdnscontroldebug.com.au
WARNING: Zone 'zzzdnscontroldebug.com.au' does not exist in the 'r53...n...m' profile and will be added automatically.
WARNING: No nameservers declared; skipping registrar. Add {no_ns:'true'} to force.
Done. 0 corrections.

Push

ROUTE53 DelegationSet N.....M configured
******************** Domain: zzzdnscontroldebug.com.au
Adding zone for zzzdnscontroldebug.com.au to route 53 account with delegationSet N.....M
ERROR: ERROR: error while getting Nameservers for zone="zzzdnscontroldebug.com.au" with provider="r53...n...m": 
Domain zzzdnscontroldebug.com.au not found in your route 53 account
Done. 0 corrections.

Expected behavior
The error returned should include that the DelegationSet 'N.....M' is full, and some suggested actions

DNS Provider
Route53

Additional context
Maybe when the DelegationSet is probed, the current number of domains, and the domain limit should also be retrieved.
Using that information, plus the number of new domains for the DelegationSet could make DNSControl fail early.

@tlimoncelli
Copy link
Contributor

CC @tresni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants