Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDNS: API error messages leak credentials #3124

Open
hmoffatt opened this issue Sep 24, 2024 · 2 comments
Open

CLOUDNS: API error messages leak credentials #3124

hmoffatt opened this issue Sep 24, 2024 · 2 comments

Comments

@hmoffatt
Copy link
Contributor

hmoffatt commented Sep 24, 2024

Describe the bug
If a CLOUDNS API error occurs, the credentials are leaked. This is because the credentials are passed in the query part of the URL, and the whole URL is printed in the error.

To Reproduce
Seen while debugging ClouDNS changes, but it would occur if you had the credentials wrong.

Expected behavior
Credentials should not be leaked in the error text.

DNS Provider

  • ClouDNS

Additional context
Add any other context about the problem here.

@cafferata
Copy link
Collaborator

Ping @pragmaton, the maintainer of the ClouDNS provider.

hmoffatt added a commit to hmoffatt/dnscontrol that referenced this issue Sep 24, 2024
hmoffatt added a commit to hmoffatt/dnscontrol that referenced this issue Sep 24, 2024
@hmoffatt
Copy link
Contributor Author

I think the simplest change is not to print the URL - change is in the referenced PR. Otherwise a sanitized URL could be printed, if this is desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants