Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EL7][st2bootstrap-el7.sh] nodejs from epel always take precedence #437

Closed
shusugmt opened this issue Mar 2, 2017 · 4 comments
Closed

Comments

@shusugmt
Copy link

shusugmt commented Mar 2, 2017

epel-release will be installed at here:
https://github.com/StackStorm/st2-packages/blob/master/scripts/st2bootstrap-el7.sh#L261

then, nodejs 4 repository will be configured at here:
https://github.com/StackStorm/st2-packages/blob/master/scripts/st2bootstrap-el7.sh#L554-L555

but it will never be used because nodejs package from epel-release is newer so while installing st2chatops, dependent installed nodejs is not the one from rpm.nodesource.com

Maybe this is just a bug of the script?

@arm4b
Copy link
Member

arm4b commented Mar 2, 2017

Thanks for the report, it's a good catch 👍

So it looks like EPEL has nodejs 6.9 while Nodesource 4 has nodejs 4.8.
Yeah, this is a time ticking bomb when EPEL could ship some newer version which will break things for us.

@s2ugimot BTW any problem you hit with nodejs 6.9?

@shusugmt
Copy link
Author

shusugmt commented Mar 2, 2017

@armab

BTW any problem you hit with nodejs 6.9?

Wish I could tell, but I'm just not using st2chatops at my installation yet...

@arm4b
Copy link
Member

arm4b commented Mar 2, 2017

@enykeev @emedvedev Do you know if there is a node version which could break the things for us?
Also is it a good reason/should we update our bootstrap scripts to newer https://rpm.nodesource.com/setup_6.x from https://rpm.nodesource.com/setup_4.x?

Additionally, for safety we can add max allowed node version in packaging spec:

@arm4b
Copy link
Member

arm4b commented Aug 22, 2017

Since we switched to nodejs6 by default for st2chatops, this is fixed now.
See StackStorm/st2chatops#78 and StackStorm/st2chatops#83 where we rely on specific major node version via packaging dependencies.

@arm4b arm4b closed this as completed Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants