Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assumptions about order of ReadDir results in tail/tail.go #268

Open
jmacd opened this issue Jan 22, 2021 · 0 comments · May be fixed by #288
Open

Assumptions about order of ReadDir results in tail/tail.go #268

jmacd opened this issue Jan 22, 2021 · 0 comments · May be fixed by #288

Comments

@jmacd
Copy link

jmacd commented Jan 22, 2021

Reporting this bug discovered in an downstream fork of this repository, here:

lightstep/opentelemetry-prometheus-sidecar#69

This can result in the sidecar exiting with a bogus corruption message when in fact nothing is wrong.

The fix is simple, see the associated PR. If it pleases a maintainer of this code, consider looking at other downstream changes in tail/tail.go that are relevant here (see listSegments()).
eseliger added a commit to eseliger/stackdriver-prometheus-sidecar that referenced this issue Aug 10, 2021
@eseliger
Backport corrupted WAL error fix
d563eca 
This PR introduces the fix added to [lightstep/opentelemetry-prometheus-sidecar here](lightstep/opentelemetry-prometheus-sidecar#71).

Closes Stackdriver#268
@eseliger eseliger linked a pull request Aug 10, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Backport corrupted WAL error fix eseliger/stackdriver-prometheus-sidecar
1 participant
@jmacd