Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support show create view for connector view (backport #49393) #49506

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 7, 2024

Why I'm doing:

What I'm doing:

support show create view for hive/trino/iceberg view
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #49393 done by [Mergify](https://mergify.com). ## Why I'm doing:

What I'm doing:

support show create view for hive/trino/iceberg view
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

(cherry picked from commit 50dbbd3)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AstToStringBuilder.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveMetadataTest.java
#	fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveViewTest.java
@mergify mergify bot added the conflicts label Aug 7, 2024
Copy link
Contributor Author

mergify bot commented Aug 7, 2024

Cherry-pick of 50dbbd3 has failed:

On branch mergify/bp/branch-3.1/pr-49393
Your branch is up to date with 'origin/branch-3.1'.

You are currently cherry-picking commit 50dbbd39ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/ast/ShowCreateTableStmt.java
	new file:   test/sql/test_hive/R/test_hive_view
	new file:   test/sql/test_hive/T/test_hive_view

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/ShowExecutor.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AstToStringBuilder.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveMetadataTest.java
	both modified:   fe/fe-core/src/test/java/com/starrocks/connector/hive/HiveViewTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Aug 7, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.1/pr-49393 branch August 7, 2024 06:44
@Youngwb Youngwb restored the mergify/bp/branch-3.1/pr-49393 branch August 7, 2024 15:21
@Youngwb Youngwb reopened this Aug 7, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) August 7, 2024 16:20
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit b965c01 into branch-3.1 Aug 7, 2024
31 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-49393 branch August 7, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants