[BugFix] Fix orc tinyint on aarch64 #49517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wyb <[email protected]>
trueeyu
approved these changes
Aug 7, 2024
alvin-celerdata
approved these changes
Aug 7, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
Why I'm doing: https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char compiler treat char as unsigned on aarch64, negative tinyint will be wrong, and the query result from orc is null. What I'm doing: use int8_t not char to cast Signed-off-by: wyb <[email protected]> (cherry picked from commit 6de3ab7)
44 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
Why I'm doing: https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char compiler treat char as unsigned on aarch64, negative tinyint will be wrong, and the query result from orc is null. What I'm doing: use int8_t not char to cast Signed-off-by: wyb <[email protected]> (cherry picked from commit 6de3ab7)
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
Why I'm doing: https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char compiler treat char as unsigned on aarch64, negative tinyint will be wrong, and the query result from orc is null. What I'm doing: use int8_t not char to cast Signed-off-by: wyb <[email protected]> (cherry picked from commit 6de3ab7)
This was referenced Aug 7, 2024
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: wyb <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: wyb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char
compiler treat
charasunsignedon aarch64,negative tinyintwill be wrong, and the query result from orc is null.What I'm doing:
use
int8_tnotcharto castFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Documentation PRs only:
If you are submitting a PR that adds or changes English documentation and have not
included Chinese documentation, then you can check the box to request GPT to translate the
English doc to Chinese. Please ensure to uncheck the Do not translate box if translation is needed.
The workflow will generate a new PR with the Chinese translation after this PR is merged.