Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IIFE #19

Closed
wants to merge 6 commits into from
Closed

Disable IIFE #19

wants to merge 6 commits into from

Conversation

steinybot
Copy link

Fixes #17

@steinybot
Copy link
Author

This is probably unnecessary. We can just add to the window object instead.

Would be nice if there was a way to assign the result of the IIFE to a global variable but AFAIK there is no way to do that with rollup.

@steinybot steinybot closed this Oct 25, 2021
@thopiddock
Copy link

I would recommend opening this again as the IIFE destroys MV3 event handlers on background service workers that must be at the top level of the file.

I'd find these changes very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content Scripts should not be IIFE
2 participants