-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steeltoe assemblies do not have strong name information #18
Comments
All future releases of Steeltoe should be signed. You can get signed packages right now if you pull 2.2.* versions from the dev feed If you are not facing some restriction on using .NET versions newer than framework 4.5.2, we'd recommend using newer Steeltoe packages. Be aware that package names changed when 2.0 was released, so the package manager won't show them as updates. Do you have a requirement for signed 1.x Steeltoe packages? |
My requirement is to consume it on netstandard2.0 projects, I tried even Steeltoe.Extensions.Configuration.CloudFoundryCore 2.1.1, same error, Do you have a requirement for signed 1.x Steeltoe packages? - NO so the signed packages will be released, which I can use in netstandard2.0 projects, any timeline on this? Thanks |
As mentioned, you can get the pre-release versions now - we should be merging dev into master this week if you'd rather pull from that feed as it is a bit more stable. We are expecting to release 2.2.0-RC1 in the next couple weeks and (barring any unforeseen circumstances) a GA release within a couple weeks after that. It would actually be helpful for us if you could confirm that the signing is working as expected for you before we push packages to nuget.org if you've got time. |
Tried below three packages got below errors, Steeltoe.Extensions.Configuration.CloudFoundryCor - v 2.2.0-dev-00328 Steeltoe.Extensions.Configuration.CloudFoundryAutoFac - v 2.2.0-dev-00328 Steeltoe.Extensions.Configuration.CloudFoundryBase - v 2.2.0-dev-00328 it seems they are not signed yet. |
Ah, right... I added package signing, not assembly signing. We will look to add strong name support for the next release after 2.2. If it turns out to be trivial we can look at adding it in a patch release as well. |
can you please provide the timelines of next release after 2.2 and patch release. |
Sorry, I don't have a real timeline to offer... We try to do feature releases approximately every 6 months. I hope to look at package signing early on in the cycle after we wrap up docs on the 2.2 release and should know more in 2-4 weeks |
Please sign the assemblies , in many development environments can't use the unsigned assemblies |
I'm viewing the signing of Steeltoe assemblies as an all or nothing scenario, where we either sign all of the assemblies or none of them. Some of the assemblies allow access to internals for their corresponding test projects and thus we'll need to either sign the test assemblies as well or change how some of that works. As such, the following dependencies all need to be signed or removed before Steeltoe can ship with signed assemblies:
|
Possible tool to aid in this issue: https://github.com/dsplaisted/strongnamer |
|
Is assembly signing still relevant to pursue for Steeltoe v4, given that since Steeltoe v3 it no longer supports running on .NET Framework?
|
When I use nuget package Steeltoe.Extensions.Configuration.CloudFoundry I am getting an error that assembly Steeltoe.Extensions.Configuration.CloudFoundry does not have strong name
CSC : error CS8002: Referenced assembly 'Steeltoe.Extensions.Configuration.CloudFoundry, Version=1.1.1.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
Yes its optional to sign the C# assemblies. but
but if assemblies are signed it will be useful for consumers who have to work with projects with strong signature.
The text was updated successfully, but these errors were encountered: