Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1809 / 2019 support for nodejs #391

Closed
pennywisdom opened this issue Feb 22, 2019 · 4 comments
Closed

1809 / 2019 support for nodejs #391

pennywisdom opened this issue Feb 22, 2019 · 4 comments

Comments

@pennywisdom
Copy link
Contributor

Hi @StefanScherer, firstly congratulations on your move to Docker! Second, and this is a general query re nodejs and windows 1809/2019. I see that under the hood things have changed regarding volume mounting and how this is now natively visible in terms of the path inside the container. I was wondering if you have found that this resolves the issues with running nodejs against scripts in a volume (especially permissions and finding the paths correctly). Have you found that this has improved things or do the problems still remain and we need to still copy the files from the mounted volume to a location created in the context of the container?

Thanks

@StefanScherer
Copy link
Owner

Thanks @pennywisdom, yes the volume mounting is fixed since 1803 as I mentioned that in nodejs/node#8897 (comment) some months ago.
So it is time to push nodejs/docker-node#362 a little further, the constraint is not to use multi-stage builds. Maybe I find some time to update my PR.

For now you can use my images that already have 1809/2019 support for the nanoserver based images.

@pennywisdom
Copy link
Contributor Author

Thanks @StefanScherer . Hmm I get some strange behaviour still when executing node scripts inside the mount. The mount itself is fine. Looks like its permissions related to me. So looks like great progress with the initial volumes issues :) . I am able to mount the volume, then copy to a new location then run the same scripts without problem. This is for nodejs version 6.16 though so might well be related to this older release.

@StefanScherer
Copy link
Owner

Oh, yes try 8 or 10 which is LTS now.

@pennywisdom
Copy link
Contributor Author

thanks @StefanScherer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants