Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors in xDrip notification / background #343

Open
fezulin opened this issue May 26, 2016 · 5 comments
Open

colors in xDrip notification / background #343

fezulin opened this issue May 26, 2016 · 5 comments

Comments

@fezulin
Copy link

fezulin commented May 26, 2016

Hi all!
Every 5 minutes the xDrip-App receives a measurement from the xDrip. Each measurement is displayed as a point in a graph. The color of the points depend on the value: (Beta5 v2.0.5_2 update 2)

  • too low: red
  • ok: blue
  • too high: orange

In discussions with Adrian I learned, that it might be planned to change these colors, to have the same colors as used in Nightscount.

  • too low: red
  • ok: green
  • too high: yellow

So far: Fully agreement. That is a good intention.

But a problem occurs in case of the background color differs from black.
I observed with Android 5.1, that the color of the background in the notification is by default white. And that I cannot change this color manually on my device. (At least: I have no idea how this can be done.)

The yellow points are difficult to recognize on the white background.
notification_white

It would be very comfortable, if the background color was defined as black:
notification_black

If there is a choice, the background color of the Widget should not be influenced by this change.

@AdrianLxM
Copy link
Collaborator

@fezulin thanks.

It would not be much work to make the chart background black for the Notification and keep it transparent in other cases.

@jstevensog how about your pebble integration. As this would cause merge conflicts (that I cannot test) it would be good to have it in first. Then I could add this without changing the pebble image generation bahaviour.

@jstevensog
Copy link
Collaborator

@AdrianLxM, I am still to get the install from the app working. I want to
automate it if possible.
But the PebbleTrend branch can probably be merged. I will get the latest
master over the weekend and get PebbleTrend rebased to it.
That should resolve any merge conflicts.
The auto install can wait. I can make the PBW available to those wanting
to try out the new trend watch face.
Won't put it on the pebble store though, that would make the older xDrips
look weird.
Cheers

On Thu, May 26, 2016 at 8:39 PM, AdrianLxM [email protected] wrote:

@fezulin https://github.com/fezulin thanks.

It would not be much work to make the chart background black for the
Notification and keep it transparent in other cases.

@jstevensog https://github.com/jstevensog how about your pebble
integration. As this would cause merge conflicts (that I cannot test) it
would be good to have it in first. Then I could add this without changing
the pebble image generation bahaviour.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#343 (comment)

John Stevens
"You are how you live, not what you have."

@jstevensog
Copy link
Collaborator

OK, I have checked PebbleTrend for merge conflicts with master and there
are none with my local branch. I just need to go through the local branch
and make sure there is nothing that cannot be pushed up. I don't think
there is, but last time I was working on it, I was looking at enhancing the
configurability of the watch face, and making the settings be done in the
Pebble watch face settings rather than in xDrip.
I am fairly sure there is no issue with the code, so if you wanted to
merge, you could do so. The watch face included in the branch should work
fine. I just cannot test it right now.
Cheers

On Fri, May 27, 2016 at 10:17 AM, John Stevens [email protected] wrote:

@AdrianLxM, I am still to get the install from the app working. I want to
automate it if possible.
But the PebbleTrend branch can probably be merged. I will get the latest
master over the weekend and get PebbleTrend rebased to it.
That should resolve any merge conflicts.
The auto install can wait. I can make the PBW available to those wanting
to try out the new trend watch face.
Won't put it on the pebble store though, that would make the older xDrips
look weird.
Cheers

On Thu, May 26, 2016 at 8:39 PM, AdrianLxM [email protected]
wrote:

@fezulin https://github.com/fezulin thanks.

It would not be much work to make the chart background black for the
Notification and keep it transparent in other cases.

@jstevensog https://github.com/jstevensog how about your pebble
integration. As this would cause merge conflicts (that I cannot test) it
would be good to have it in first. Then I could add this without changing
the pebble image generation bahaviour.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#343 (comment)

John Stevens
"You are how you live, not what you have."

John Stevens
"You are how you live, not what you have."

@jstevensog
Copy link
Collaborator

Pushed the latest PebbleTrend.
Cheers

On Mon, May 30, 2016 at 7:31 AM, John Stevens [email protected] wrote:

OK, I have checked PebbleTrend for merge conflicts with master and there
are none with my local branch. I just need to go through the local branch
and make sure there is nothing that cannot be pushed up. I don't think
there is, but last time I was working on it, I was looking at enhancing the
configurability of the watch face, and making the settings be done in the
Pebble watch face settings rather than in xDrip.
I am fairly sure there is no issue with the code, so if you wanted to
merge, you could do so. The watch face included in the branch should work
fine. I just cannot test it right now.
Cheers

On Fri, May 27, 2016 at 10:17 AM, John Stevens [email protected]
wrote:

@AdrianLxM, I am still to get the install from the app working. I want
to automate it if possible.
But the PebbleTrend branch can probably be merged. I will get the latest
master over the weekend and get PebbleTrend rebased to it.
That should resolve any merge conflicts.
The auto install can wait. I can make the PBW available to those wanting
to try out the new trend watch face.
Won't put it on the pebble store though, that would make the older xDrips
look weird.
Cheers

On Thu, May 26, 2016 at 8:39 PM, AdrianLxM [email protected]
wrote:

@fezulin https://github.com/fezulin thanks.

It would not be much work to make the chart background black for the
Notification and keep it transparent in other cases.

@jstevensog https://github.com/jstevensog how about your pebble
integration. As this would cause merge conflicts (that I cannot test) it
would be good to have it in first. Then I could add this without changing
the pebble image generation bahaviour.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#343 (comment)

John Stevens
"You are how you live, not what you have."

John Stevens
"You are how you live, not what you have."

John Stevens
"You are how you live, not what you have."

@danpowell88
Copy link

danpowell88 commented Jun 2, 2016

I'd like to add that having the green/yellow colors as current on a black background is really difficult to tell the difference to someone like me who is partially colour blind.

screenshot_2016-06-02-21-54-34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants