Multiple projects with same name but different provider

[v-g-ustinov]

We have two projects with same names on bitbucket and github. It is different projects but have the same names and same names for repositories.
Bitbucket's one is already configured and now I get "error:409 project already exists" if I try to add the repo with same name from github. As project names and repos are not global and really can have the same names it should be prefixed some how locally or fixed other way.

[xgalen]

Hi @v-g-ustinov ,

As you pointed, strider only matches the name field:

strider/lib/routes/api/repo.js

Line 257 in 58449c2

Project.findOne({name: name}, projectResult);

The name is composed by the organization / repo's name, so we can suppose that your organization has the same name also.

The easy patch could be change the previous line by something like (just add a new filter by provider.id):
Project.findOne({name: name, provider.id: provider.id}, projectResult);

But I don't know if this can has unexpected consequences. Maybe you can change the line, try it and if it works, do make a PR.

Alfredo

[knownasilya]

It would cause issues, because the provider isn't reflected in the url so strider wouldn't know which project you mean..

[knownasilya]

This would actually be an easy implementation detail most likely.