Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #2

Open
lil-skelly opened this issue Jul 22, 2024 · 2 comments
Open

Suggestions #2

lil-skelly opened this issue Jul 22, 2024 · 2 comments

Comments

@lil-skelly
Copy link

Consider splitting the project into multiple files to make further development easier for you and other contributors.

I also suggest specifying specific versions of the libraries listed in requirements.txt to prevent nasty errors on users with old installs as well as documenting your code.

Things like these will prove extremely useful.

@Stuub
Copy link
Owner

Stuub commented Jul 22, 2024

Good ideas man.

This project kinda started as a meme for creating something that shouldn't be made in Python, decided to ride the meme out and not refactor with modules. Think it'll bite me in time soon to come, will change that 😆

requirements.txt desperately needs specific versions, you're right. Helped a couple of users that had deprecated versions, causing webdriver issues.

Thank you big smelly, you a real one

@lil-skelly
Copy link
Author

For sure homie, us developers should have each others back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants