-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library project #81
Comments
Hi, I'm guessing you're trying to export geometry that doesn't exist in the document. For that I'd create a new document with Let me know if this helps |
Hi @jrz371, no, in our plugin we are generating a .glb byte array from existing selected geometry, which never gets saved into a file on disk. The Rhino command saves a file, but we tweaked the calling code a bit to retrieve a memory stream. Also, as you mention, we created a separate class to pass the parameters, as the existing one is too tightly coupled with the plugin's settings. I don't think an additional project, clean of Rhino plugin and command specific code, would add much overhead, and might help structure the project a bit better, but ofcourse it's your decision if you opt for this. |
I still think this is a few extra steps of work since you could export to a temporary file and read back in the byte array from disk. You can also use |
No worries, for the time being we will continue to use our fork. |
If you don't mind sharing, what's your use case? I'd like to add a note to our YouTrack issue about accessing export settings from Rhino |
The plugin has a panel where the UI is created by web technologies (using a webview control). It includes a three.js viewer where we preview Rhino geometry (that's why ideally we want to send the geometry in-memory, without access to disk). |
Hi, I am planning to use this project as a dependency to a Rhino plugin. The readme mentions it can be used by developers in this way.
The project seems to work great, the only issue is that it's structured only as a Rhino plugin. It would be great if you could separate it into two projects, a library and a Rhino plugin. The library can then be used by other Rhino plugins directly without having to make changes to this project.
For the time being, I've created a fork with this additional library project, making as few changes as possible. You can have a look here:
https://github.com/visose/glTF-Bin/tree/library
If done properly, it would be better to restructure the folders and move the code files around, rather than reference them as I've done here.
The text was updated successfully, but these errors were encountered: