Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deinterlacing is not quite working right #354

Open
signumnova opened this issue Oct 6, 2023 · 1 comment
Open

Deinterlacing is not quite working right #354

signumnova opened this issue Oct 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@signumnova
Copy link
Contributor

What it is supposed to do is "double" the number of frames being rendered by combining the alternate frames, and applying the deinterlace filter to each combination to reduce the combing effect.

So for a 1080i25 picture you receive 25 odds and 25 evens per second.

These need to be combined like this to produce 50 unique frames per sec:

1: O1 + E1
2: O1 + E2
3: O2 + E2
4: O2 + E3 etc etc, because that marries with the temporal manner in which the alternating fields are captured essentially.

I'm not really sure how you ask DirectX to do this, but the current code in flyleaf is not getting the frame doubling effect right, it's just combining O1 and E1 and then O2 and E2, still producing 25 fps, and applying the deinterlace filter over the top.

The image quality (clarity) is poor as well because we've just traded off a bit less motion combing for a blurrier looking overall picture.

VLC gets this right, however it is doing it.

@SuRGeoNix
Copy link
Owner

SuRGeoNix commented Oct 8, 2023

There is a lot of space for Deinterlacing improvements as currently Flyelaf supports only Bob method with D3D11VP. I think it works as it supposed to be but Bob is just not good enough. The problem is that with the current design (frames coming from the video decoder) is not easy to create prev/next references. Additionally, I'm not very familiar with the Deinterlacing and is not easy to implement with FlyelafVP and pixel shaders. I will do more research and try to include it in the next major (v4.0) with the new design.

@SuRGeoNix SuRGeoNix added the enhancement New feature or request label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants