-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ER modeling #32
ER modeling #32
Conversation
Add new issue template
added the project board to the template
Nice job BK. Could be removed this file I believe your branch is not up to date. Please do a rebase to fix that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an additional comment
Doc/ER_diagram.md
Outdated
STUDENT ||--|| CALENDAR : has | ||
MENTOR ||--|| CALENDAR : has | ||
MENTOR ||--|{ WEEKDAYS : tutors | ||
ADMIN ||--o{ EVENTS : posts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a string password
field here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first section represents Entity relationships and each constitutes its own table. Do you mean to have a Password entity? or if you are referring to string password, let me know the table so I can add it@kirubeltadesse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. clicked at the wrong place by mistake :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a suggestion Kira come up with while we were talking.
Doc/ER_diagram.md
Outdated
@@ -0,0 +1,63 @@ | |||
# This diagram represents the ER relationship diagram among the entities below |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a title and make the rest of the information a paragraph: for better formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay good
string Jnumber | ||
string email | ||
string role | ||
string userName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mean add the password here. Next to the userName
Doc/ER_diagram.md
Outdated
STUDENT ||--|| CALENDAR : has | ||
MENTOR ||--|| CALENDAR : has | ||
MENTOR ||--|{ WEEKDAYS : tutors | ||
ADMIN ||--o{ EVENTS : posts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. clicked at the wrong place by mistake :)
Doc/ER_diagram.md
Outdated
int calendar_id PK | ||
int weekday_id FK | ||
} | ||
WEEKDAYS { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STUDENT ||--|| CALENDAR : has | ||
MENTOR ||--|| CALENDAR : has | ||
USER { | ||
int user_id PK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The datatype of user_id seems to be inconsistent. It is an int datatype here but on STUDENT, MENTOR and SIGNIN it seems to be of string data type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinaolmelak this is closed PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, I have added these changes to my pull request #44
USER { | ||
int user_id PK | ||
string fullName | ||
string Jnumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set this to camel case naming convention? (i.e string jNumber)
string user_id FK | ||
} | ||
MENTOR { | ||
int mentor_id PK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data type of mentor_id
is int here but under EVENTS it is a string.
USER { | ||
int user_id PK | ||
string fullName | ||
string Jnumber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also set the data type of jNumber to int
?
Description
This is basic ER relationship diagram that is based on UML diagram. It's dependent on MermaidJS
Fixes #19
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
It has been tested locally and on live editor. A link is included to help the developer replicate the same test
Test Configuration:
N/A
Checklist: