Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER modeling #32

Closed
wants to merge 9 commits into from
Closed

ER modeling #32

wants to merge 9 commits into from

Conversation

BAbate
Copy link
Collaborator

@BAbate BAbate commented Jun 2, 2022

Description

This is basic ER relationship diagram that is based on UML diagram. It's dependent on MermaidJS

Fixes #19

Type of change

Please delete options that are not relevant.

  • new features
  • this change itself is documentation that developers refer to construct the database

How Has This Been Tested?

It has been tested locally and on live editor. A link is included to help the developer replicate the same test

Test Configuration:
N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [N/A] My changes generate no new warnings
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • [N/A] New and existing unit tests pass locally with my changes
  • [N/A] Any dependent changes have been merged and published in downstream modules

@kirubeltadesse kirubeltadesse changed the title Develop ER modelling Jun 2, 2022
@kirubeltadesse
Copy link
Collaborator

kirubeltadesse commented Jun 2, 2022

Nice job BK. Could be removed this file
Doc/.UML_diagram.md.swp

I believe your branch is not up to date. Please do a rebase to fix that!

@kirubeltadesse kirubeltadesse changed the title ER modelling ER modeling Jun 4, 2022
Copy link
Collaborator

@kirubeltadesse kirubeltadesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an additional comment

Doc/ER_diagram.md Show resolved Hide resolved
STUDENT ||--|| CALENDAR : has
MENTOR ||--|| CALENDAR : has
MENTOR ||--|{ WEEKDAYS : tutors
ADMIN ||--o{ EVENTS : posts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a string password field here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first section represents Entity relationships and each constitutes its own table. Do you mean to have a Password entity? or if you are referring to string password, let me know the table so I can add it@kirubeltadesse

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. clicked at the wrong place by mistake :)

Copy link
Collaborator

@Getnet12 Getnet12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a suggestion Kira come up with while we were talking.

@@ -0,0 +1,63 @@
# This diagram represents the ER relationship diagram among the entities below
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a title and make the rest of the information a paragraph: for better formatting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay good

Doc/ER_diagram.md Outdated Show resolved Hide resolved
string Jnumber
string email
string role
string userName
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mean add the password here. Next to the userName

STUDENT ||--|| CALENDAR : has
MENTOR ||--|| CALENDAR : has
MENTOR ||--|{ WEEKDAYS : tutors
ADMIN ||--o{ EVENTS : posts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. clicked at the wrong place by mistake :)

int calendar_id PK
int weekday_id FK
}
WEEKDAYS {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-06-06 at 12 34 25 PM

Should we add an entry for 'week' here?

Doc/ER_diagram.md Show resolved Hide resolved
@BAbate BAbate deleted the branch Swarmies:develop June 11, 2022 04:28
@BAbate BAbate closed this Jun 11, 2022
@BAbate BAbate deleted the develop branch June 11, 2022 04:28
@BAbate BAbate restored the develop branch June 11, 2022 04:29
STUDENT ||--|| CALENDAR : has
MENTOR ||--|| CALENDAR : has
USER {
int user_id PK
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datatype of user_id seems to be inconsistent. It is an int datatype here but on STUDENT, MENTOR and SIGNIN it seems to be of string data type

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinaolmelak this is closed PR?

Copy link
Collaborator

@dinaolmelak dinaolmelak Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I have added these changes to my pull request #44

USER {
int user_id PK
string fullName
string Jnumber
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set this to camel case naming convention? (i.e string jNumber)

string user_id FK
}
MENTOR {
int mentor_id PK
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data type of mentor_id is int here but under EVENTS it is a string.

USER {
int user_id PK
string fullName
string Jnumber
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also set the data type of jNumber to int?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERD modeling
4 participants