Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add student model #66

Merged
merged 1 commit into from
Aug 18, 2023
Merged

feat(core): add student model #66

merged 1 commit into from
Aug 18, 2023

Conversation

Roberamelaek
Copy link
Collaborator

@Roberamelaek Roberamelaek commented Aug 8, 2023 •
edited
Loading

Description

student model that has first last name and email

Changes

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This code is tested locally in the service container

@kirubeltadesse kirubeltadesse marked this pull request as ready for review August 9, 2023 06:52
@Roberamelaek Roberamelaek changed the base branch from local to develop August 9, 2023 18:21
kirubeltadesse
kirubeltadesse reviewed Aug 13, 2023
View reviewed changes
Copy link
Collaborator

@kirubeltadesse kirubeltadesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best if you rebased against the upstream develop branch before we can review this :) Good job by the way 👍🏼

@kirubeltadesse kirubeltadesse changed the title Local feat(core): add student model Aug 15, 2023
kirubeltadesse
kirubeltadesse reviewed Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@kirubeltadesse kirubeltadesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the necessary changes

api/serializers.py Outdated Show resolved Hide resolved
backend/admin.py Outdated Show resolved Hide resolved
frontend/install-dev-packages.sh Outdated Show resolved Hide resolved
.manage.py.swp Outdated Show resolved Hide resolved
@Roberamelaek Roberamelaek changed the title feat(core): add student model feat(core): Add student model Aug 17, 2023
@Roberamelaek Roberamelaek changed the title feat(core): Add student model feat(core): add student model Aug 17, 2023
@Roberamelaek Roberamelaek reopened this Aug 18, 2023
@Roberamelaek Roberamelaek self-assigned this Aug 18, 2023
kirubeltadesse
kirubeltadesse approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@kirubeltadesse kirubeltadesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@kirubeltadesse kirubeltadesse merged commit cb464f9 into Swarmies:develop Aug 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirubeltadesse kirubeltadesse kirubeltadesse approved these changes

@dinaolmelak dinaolmelak Awaiting requested review from dinaolmelak

Assignees

@Roberamelaek Roberamelaek

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Roberamelaek @kirubeltadesse