Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new test container #80

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Roberamelaek
Copy link
Collaborator

Description

a new container called test for the django svc container

Fixes #35

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally in the terminal

@kirubeltadesse kirubeltadesse marked this pull request as ready for review September 1, 2023 03:37
Copy link
Collaborator

@kirubeltadesse kirubeltadesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rename this feat(cicd) since this is a testing container.

Dockerfile.test Show resolved Hide resolved
volumes:
- .:/workspace
ports:
- "8000:8000"
- "5678:5678"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why you were getting the error that you screenshot on Discord. It would be best if you had the previous changes up to date.

environment:
- POSTGRES_DB=saptable
- POSTGRES_USER=rootUser
- POSTGRES_PASSWORD=rootPassword
depends_on:
- db
command: ["bash", "-c",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lines are also need for your debugger to work locally

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

docker-compose.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating the Test container
2 participants