Rollbar: 2clove bug

[johnhutch]

ArgumentError: '2clove' Unit not recognized

[johnhutch]

Asked question of ruby-units author for how best to handle unit validity checks.

olbrich/ruby-units#156

[jon-athan-hall]

I'll review the rest of this, but take a look at the test I built (including the nifty custom matcher I researched) @johnhutch

[johnhutch]

shit, man. That custom matcher is fantastic. Any chance you saved the link where you read about it? I'd like to pinboard it.

As for the rest of the issue, review approved?

[jon-athan-hall]

app/helpers/application_helper.rb
Is the pluralization of name backwards?

app/models/ingredient.rb

if self.unitless? || ing.unitless?
  if self.unitless? && ing.unitless?

Is this redundant? Or is it important to know if just one is unitless for the next else block? I see it twice in this file

[johnhutch]

app/helpers/application_helper.rb
Is the pluralization of name backwards?

nope.

app/models/ingredient.rb

It's important to know if just one is unitless because if EITHER is unitless, we can't try to do unit math with it.

Another way to state the logic tree would be:

If neither item is unitless, add or subtract as units.
If only one item is unitless, skip this "hit" and keep looking through the rest of the ingredients
if both items are unitless, add or subtract whole amounts.

[jon-athan-hall]

Pushed to PROD. Ready for the second round of QA.

[johnhutch]

Tested on live by adding a recipe with the following ingredient list (which originally tripped the error -- sorry, this should have been in the bug description):

5 tbsp soy sauce
4 tbsp mild or hot chili powder
3 tbsp five-spice powder
2 tbsp light muscovado sugar
2 cloves garlic, finely chopped
4 cm piece of fresh ginger, peeled and finely chopped
6 1/2 lbs boneless pork shoulder, rind removed