Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI variantDerivations appear in some cases, while variants appear in others #6

Open
wdrav opened this issue Oct 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@wdrav
Copy link
Collaborator

wdrav commented Oct 12, 2023

The current state of the code proportions all variableFeatures to have variants, missing out on the variantDerivation descriptor in some cases. When should these tags appear, as opposed to the simple variant?

@wdrav wdrav added the bug Something isn't working label Oct 12, 2023
@jakebeal
Copy link

The type of the link depends on the type of the object being linked:

  • A variant links to a Component
  • A variantDerivation links to a CombinatorialDerivation
  • A variantCollection links to a Collection

There is a separate concern about optimizing degenerate CombinatorialDerivation objects into Collection or Component objects, but that's a post-processing step, not a first pass emission.

@wdrav
Copy link
Collaborator Author

wdrav commented Oct 17, 2023

Excellent, thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants